Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 1.0.0 -> 1.1.0 #64381

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@mguentner
Copy link
Contributor

commented Jul 6, 2019

Motivation for this change

@Ralith @fpletz

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Ekleog Jul 6, 2019

@nyanloutre nyanloutre referenced this pull request Jul 6, 2019

Closed

matrix-synapse: 1.0.0 -> 1.1.0 #64382

4 of 10 tasks complete
@nyanloutre

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2019

@GrahamcOfBorg build nixosTests.matrix-synapse

@Ekleog

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

Test failure looks like a spurious timeout of the postgresql unit, let's attempt it again.

@GrahamcOfBorg build nixosTests.matrix-synapse

@nyanloutre

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2019

It timed out again :(

@Ekleog

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Let's see if it's postgresql that's broken, if not then it's most likely a bug in this PR for some reason I can't think of right now, potentially with some postgresql activation script or similar.

@GrahamcOfBorg build nixosTests.postgresql

@mguentner

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

The test runs smoothly on my local machine

@nyanloutre

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Same for me, I can run the test successfully on my machine

@bachp

bachp approved these changes Jul 8, 2019

Copy link
Contributor

left a comment

Deployed and working on my server

@Ekleog

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Looks like it works here too.

@grahamc Any idea what could be causing this postgresql timeout on ofborg and seemingly only there, that has been confirmed twice?

@mguentner

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

I believe we can merge this as multiple people have confirmed that It works!™.
The problem with @GrahamcOfBorg seems to be an "Who tests the testers?" issue.

@Ekleog

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

Sounds like some ofborg builders are running in VMs, which mean the tests may run slower in there. As it sounds like something that's a tester issue indeed and not some impurity, merging :)

@Ekleog Ekleog merged commit 2db3a7d into NixOS:master Jul 18, 2019

16 of 19 checks passed

nixosTests.matrix-synapse on x86_64-darwin No attempt
Details
nixosTests.matrix-synapse on x86_64-linux Timed out, unknown build status
Details
nixosTests.postgresql on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nixosTests.matrix-synapse on aarch64-linux Success
Details
nixosTests.postgresql on aarch64-linux Success
Details
nixosTests.postgresql on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.