Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: 18.1 -> 18.3 #64383

Open
wants to merge 1 commit into
base: master
from

Conversation

@peterhoeg
Copy link
Member

commented Jul 6, 2019

Motivation for this change

Upstream update from 18.1 to 18.3 (bug fix release).

There are some minor changes to make the libdvd{css,nav,read} dependencies build as well (now they all do), but the kodi build system requires some changes in order to actually use them instead of force building them during the main kodi build.

Cc: @domenkozar @titanous @edwtjo @sephalon

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@domenkozar

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

@GrahamcOfBorg build kodi

};

cmakeProto = fetchurl {
url = "https://raw.githubusercontent.com/pramsey/libght/master/cmake/modules/CheckPrototypeExists.cmake";

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Jul 29, 2019

Member

Since this is on master it isn't stable.
Is it possible you could just add this file into nixpkgs?

This comment has been minimized.

Copy link
@peterhoeg

peterhoeg Jul 29, 2019

Author Member

That repo hasn't changed in 4 years but you are of course correct - it isn't stable. I'll make it reference the specific commit instead. I don't like adding build files to nixpkgs if we can at all avoid it. This really should go upstream.

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

The fixes here are certainly rather manual.

I'm guessing there's no way around it, but maybe reports upstream could help?

@peterhoeg

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

I'm guessing there's no way around it, but maybe reports upstream could help?

That's absolutely the way to go, yes.

@peterhoeg peterhoeg force-pushed the peterhoeg:u/kodi branch from d4705b7 to e712667 Jul 29, 2019

@peterhoeg peterhoeg closed this Jul 29, 2019

@peterhoeg peterhoeg deleted the peterhoeg:u/kodi branch Jul 29, 2019

@peterhoeg peterhoeg restored the peterhoeg:u/kodi branch Jul 29, 2019

@peterhoeg

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

This isn't meant to be closed. Sorry guys.

@peterhoeg peterhoeg reopened this Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.