Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: build-rust-crate: fix for binary crate building. #64385

Open
wants to merge 1 commit into
base: master
from

Conversation

@dnaq
Copy link
Contributor

commented Jul 6, 2019

See #64313.

build-rust-crate used to always build a crate that had a source file
with the same name as the crate as a library crate. This would break in
the cases of the crate being a binary crate containing a source file
with the same name, e.g. in xargo.

Cargo used to erroneously allow a crate with the following contents in it's cargo
toml:

[lib]
name = "foo"

having its main source file named src/foo.rs. This is behaviour that
cargo warns about.

This pull request is marked as WIP because the version of way-cooler
that is in nixpkgs depends on an old version of the crate c_vec that
assumed the erroneous behaviour of cargo. Unfortunately this pull
request will make the build of way-cooler fail until the dependency is
updated to a new version.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dnaq

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

@dnaq

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

@miltador would you like to chime in on this pull request?

WIP: build-rust-crate: fix for binary crate building.
See #64313.

build-rust-crate used to always build a crate that had a source file
with the same name as the crate as a library crate. This would break in
the cases of the crate being a binary crate containing a source file
with the same name, e.g. in xargo.

Cargo used to erroneously allow a crate with the following contents in it's cargo
toml:
```toml
[lib]
name = "foo"
```
having its main source file named `src/foo.rs`. This is behaviour that
cargo warns about.

This pull request is marked as WIP because the version of way-cooler
that is in nixpkgs depends on an old version of the crate `c_vec` that
assumed the erroneous behaviour of cargo. Unfortunately this pull
request will make the build of way-cooler fail until the dependency is
updated to a new version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.