Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.jpylyzer: init at 1.18.0, use to enable openjpeg tests #64391

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@risicle
Copy link
Contributor

commented Jul 6, 2019

Motivation for this change

jpylyzer is a "JP2 (JPEG 2000 Part 1) image validator and properties extractor". Added as a python library and application.

openjpeg uses this in its test suite. It seems to me it would be useful to enable the tests for openjpeg, with it being one of those packages with a huge list of reverse dependencies, making nox-review a far less convenient proxy for checking an openjpeg package's correctness.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

risicle added some commits Jul 6, 2019

pythonPackages.jpylyzer: init at 1.18.0
include as application too

@risicle risicle requested a review from FRidh as a code owner Jul 6, 2019

@FRidh FRidh changed the base branch from master to staging Jul 11, 2019

@FRidh FRidh merged commit 3e5ccd4 into NixOS:staging Jul 17, 2019

13 of 15 checks passed

openjpeg on aarch64-linux Failure
Details
openjpeg on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

pull bot pushed a commit to avitex/nixpkgs that referenced this pull request Jul 26, 2019

openjpeg_1: fix build after NixOS#64391
That PR has enabled tests for both openjpeg_1 and openjpeg_2, but it did not
support the tests in openjpeg_1.

Tomahna added a commit to Tomahna/nixpkgs that referenced this pull request Aug 3, 2019

openjpeg_1: fix build after NixOS#64391
That PR has enabled tests for both openjpeg_1 and openjpeg_2, but it did not
support the tests in openjpeg_1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.