Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newsboat: 2.15 -> 2.16.1 #64398

Merged
merged 1 commit into from Jul 7, 2019

Conversation

@dywedir
Copy link
Contributor

commented Jul 6, 2019

Motivation for this change

https://github.com/newsboat/newsboat/blob/master/CHANGELOG.md#2161---2019-06-26

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @dotlambda @nicknovitski

@mmahut

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

Failures on darwin.

make[1]: *** [Makefile:414: all-recursive] Error 1
make: *** [Makefile:370: all] Error 2
thread 'main' panicked at '
command did not execute successfully, got: exit code: 2

build script failed, must exit now', /private/tmp/nix-build-newsboat-2.16.1.drv-0/newsboat-2.16.1-vendor/gettext-sys/build.rs:251:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

builder for '/nix/store/5g9lns62qx667j7khk3r55d0rkfyrwrf-newsboat-2.16.1.drv' failed with exit code 101
error: build of '/nix/store/5g9lns62qx667j7khk3r55d0rkfyrwrf-newsboat-2.16.1.drv' failed
  • reviewed the diff and commit messages
  • run nix-review without any failures
  • run and tested the binaries

@dywedir dywedir force-pushed the dywedir:newsboat branch from 9635afa to b088f23 Jul 7, 2019

@teto teto merged commit e6e58a2 into NixOS:master Jul 7, 2019

16 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
newsboat on aarch64-linux Success
Details
newsboat on x86_64-darwin Success
Details
newsboat on x86_64-linux Success
Details

@dywedir dywedir deleted the dywedir:newsboat branch Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.