Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.spacy: loosen dependency version bounds #64401

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@mattmelling
Copy link
Contributor

commented Jul 6, 2019

Motivation for this change

python37Packages.spacy depends on 0.32.0,<0.33.0, but wheel has recently been updated to 0.33.4. This change removes the <0.33.0 restriction to allow compatibility with future versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mattmelling mattmelling requested a review from FRidh as a code owner Jul 6, 2019

@mattmelling mattmelling force-pushed the mattmelling:spacy-wheel-fix branch from 13e9c12 to 314110e Jul 7, 2019

@mattmelling

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2019

I force pushed an update after somehow accidentally deleting a char between testing and committing - only noticed this evening during a rebuild while looking at another package. i hope this is OK.

@jonringer
Copy link
Contributor

left a comment

Title of PR and commit should be pythonPackages.spacy: .... I would do "loosen dependency version bounds" or something similar

this is what is mean by pkg-name in CONTRIBUTING

@mattmelling

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

@jonringer Thanks for the feedback. Should I amend the commit message and simply edit the PR title? Or would it be more appropriate to close and create a new PR to correct this?

@FRidh

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Amend.

@jonringer

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

Sorry, i thought i replied to this. Yes, you should just amend an existing PR.

Plenty of people force push changes, so that the commit history looks nice on master. :)

@mattmelling mattmelling force-pushed the mattmelling:spacy-wheel-fix branch from 314110e to b4a657e Jul 10, 2019

@mattmelling mattmelling changed the title python: spacy: wheel>=0.32.0,<0.33.0 -> wheel>=0.32.0 pythonPackages.spacy: loosen dependency version bounds Jul 10, 2019

@mattmelling

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Thanks for the feedback guys! :)

@FRidh FRidh merged commit 00898f0 into NixOS:master Jul 11, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.