Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.myfitnesspal: init at 1.13.3 #64422

Merged
merged 2 commits into from Nov 7, 2019

Conversation

@bhipple
Copy link
Contributor

bhipple commented Jul 7, 2019

Motivation for this change

This is a python library for downloading data from the MyFitnessPal API, which is useful for users who want to chart/graph/visualize their data with other tools, such as seaborn or matplotlib.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple bhipple requested a review from FRidh as a code owner Jul 7, 2019
@bhipple

This comment has been minimized.

Copy link
Contributor Author

bhipple commented Jul 7, 2019

@GrahamcOfBorg build python2Packages.myfitnesspal python2Packages.measurement python3Packages.myfitnesspal python3Packages.measurement

postPatch = ''
sed -i 's/keyring>=.*/keyring/' requirements.txt
sed -i 's/keyrings.alt>=.*/keyrings.alt/' requirements.txt
'';

This comment has been minimized.

Copy link
@bhipple

bhipple Jul 7, 2019

Author Contributor

Both modules pass all of their test cases, but I also verified manually that the package works; keyring appears to increment major versions very frequently so I just stripped the version bound entirely rather than loosening it to what we currently have.

Copy link
Contributor

jonringer left a comment

Kind of a nit pick, but i would just import lib instead of stdenv.

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Jul 27, 2019

squash commits so there is one per package

@bhipple bhipple force-pushed the bhipple:add/myfitnesspal branch from 25d3384 to b0fd855 Jul 27, 2019
@bhipple

This comment has been minimized.

Copy link
Contributor Author

bhipple commented Jul 27, 2019

Commits now properly squashed per package

@bhipple

This comment has been minimized.

Copy link
Contributor Author

bhipple commented Aug 4, 2019

Ping @FRidh, I have squashed the commits as requested. I believe this should be ready for merge, but if not let me know and I'm happy to update further.

@matthewbauer matthewbauer merged commit dae8a71 into NixOS:master Nov 7, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bhipple bhipple deleted the bhipple:add/myfitnesspal branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.