Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-maintenance-mode: init at 0.13.1 #64520

Merged
merged 1 commit into from Sep 4, 2020

Conversation

@MrMebelMan
Copy link
Contributor

@MrMebelMan MrMebelMan commented Jul 9, 2019

Motivation for this change

Adding a missing Django package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@lsix lsix left a comment

Thanks for the PR,

I added comments in the review that should be addressed before merging.

mock, django }:
buildPythonPackage rec {
pname = "django-maintenance-mode";
version = "0.13.1";

This comment has been minimized.

@lsix

lsix Jul 9, 2019
Member

According to https://pypi.org/project/django-maintenance-mode/ there is a 0.13.3 version available. Any specific reason not to use it?

This comment has been minimized.

@MrMebelMan

MrMebelMan Jul 10, 2019
Author Contributor

Well, not really, I am using it with an older version of django on one of my private projects... I'll bump it, sorry!

This comment has been minimized.

@risicle

risicle Jul 10, 2019
Contributor

I sympathize with being stuck on older versions of e.g. django - is dropping support for older djangos a deliberate move in 0.13.3 by the project authors? If not, do let them know it's not working for you.

@MrMebelMan MrMebelMan force-pushed the MrMebelMan:init/django-maintenance-mode branch from 42e1840 to 90bd022 Jul 10, 2019
@MrMebelMan
Copy link
Contributor Author

@MrMebelMan MrMebelMan commented Jul 10, 2019

bumped the version to 0.13.3, removed mock, changed src to fetch from github to be able to run tests, quoted the homepage URL

@MrMebelMan MrMebelMan force-pushed the MrMebelMan:init/django-maintenance-mode branch from 90bd022 to 8bdc066 Jul 12, 2019
@mmahut
Copy link
Member

@mmahut mmahut commented Aug 12, 2019

@GrahamcOfBorg build django-maintenance-mode

@mmahut
Copy link
Member

@mmahut mmahut commented Aug 13, 2019

@MrMebelMan do you mind rebasing this?

@MrMebelMan MrMebelMan force-pushed the MrMebelMan:init/django-maintenance-mode branch from 8bdc066 to 8879f3e Aug 14, 2019
@MrMebelMan
Copy link
Contributor Author

@MrMebelMan MrMebelMan commented Aug 14, 2019

@MrMebelMan do you mind rebasing this?

done!

@mmahut
Copy link
Member

@mmahut mmahut commented Aug 15, 2019

@GrahamcOfBorg build django-maintenance-mode

@mmahut
Copy link
Member

@mmahut mmahut commented Jan 22, 2020

Sorry, dropped the ball on this, do you mind rebasing again?:)

@mmahut
Copy link
Member

@mmahut mmahut commented Jan 22, 2020

And maybe updating to latest.

@stale
Copy link

@stale stale bot commented Jul 20, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale label Jul 20, 2020
@MrMebelMan MrMebelMan force-pushed the MrMebelMan:init/django-maintenance-mode branch from 8879f3e to 91364bd Sep 3, 2020
@MrMebelMan MrMebelMan requested a review from jonringer as a code owner Sep 3, 2020
@stale stale bot removed the 2.status: stale label Sep 3, 2020
@MrMebelMan
Copy link
Contributor Author

@MrMebelMan MrMebelMan commented Sep 3, 2020

Sorry for the late reaction. Rebased master & updated django-maintenance-mode to the latest version.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 64520 1

2 packages built:
  • python37Packages.django-maintenance-mode
  • python38Packages.django-maintenance-mode

@jonringer jonringer merged commit a24cac6 into NixOS:master Sep 4, 2020
17 checks passed
17 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91364bd"; rev="91364bd28b255026751180c36f7c12824aff7347"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91364bd"; rev="91364bd28b255026751180c36f7c12824aff7347"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91364bd"; rev="91364bd28b255026751180c36f7c12824aff7347"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91364bd"; rev="91364bd28b255026751180c36f7c12824aff7347"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91364bd"; rev="91364bd28b255026751180c36f7c12824aff7347"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91364bd"; rev="91364bd28b255026751180c36f7c12824aff7347"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91364bd"; rev="91364bd28b255026751180c36f7c12824aff7347"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@MrMebelMan MrMebelMan deleted the MrMebelMan:init/django-maintenance-mode branch Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.