Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tacacs+: init 4.0.4.28 #64595

Merged
merged 1 commit into from Sep 1, 2019

Conversation

@0x4A6F
Copy link
Contributor

commented Jul 10, 2019

Motivation for this change

Adding package for a TACACS+ implementation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@GrahamcOfBorg build tacacs+

@0x4A6F

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

I"m not certain, how to proceed on the licensing dimension of this PR.

   Copyright (c) 1995-1998 by Cisco systems, Inc.

   Permission to use, copy, modify, and distribute this software for
   any purpose and without fee is hereby granted, provided that this
   copyright and permission notice appear on all copies of the
   software and supporting documentation, the name of Cisco Systems,
   Inc. not be used in advertising or publicity pertaining to
   distribution of the program without specific prior permission, and
   notice be given in supporting documentation that modification,
   copying and distribution is by permission of Cisco Systems, Inc.

   Cisco Systems, Inc. makes no representations about the suitability
   of this software for any purpose.  THIS SOFTWARE IS PROVIDED ``AS
   IS'' AND WITHOUT ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
   WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
   FITNESS FOR A PARTICULAR PURPOSE.

@0x4A6F 0x4A6F force-pushed the 0x4A6F:master-tacacs+ branch from 41bbc8c to ea17ad2 Jul 18, 2019

@0x4A6F

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

@0x4A6F 0x4A6F force-pushed the 0x4A6F:master-tacacs+ branch from ea17ad2 to 582f073 Aug 22, 2019

@aanderse
Copy link
Contributor

left a comment

This seems like a package that might benefit from also having a NixOS service. If that is true, were you interested in working on that as well?

pkgs/servers/tacacs+/default.nix Outdated Show resolved Hide resolved
pkgs/servers/tacacs+/default.nix Outdated Show resolved Hide resolved
pkgs/servers/tacacs+/default.nix Outdated Show resolved Hide resolved
pkgs/servers/tacacs+/default.nix Show resolved Hide resolved

@0x4A6F 0x4A6F force-pushed the 0x4A6F:master-tacacs+ branch 2 times, most recently from ebed406 to 3c213e9 Aug 31, 2019

@0x4A6F

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

This seems like a package that might benefit from also having a NixOS service. If that is true, were you interested in working on that as well?

Yes, I'd like to work on a service after this PR.

@0x4A6F 0x4A6F force-pushed the 0x4A6F:master-tacacs+ branch from 3c213e9 to fc4455b Aug 31, 2019

@0x4A6F 0x4A6F requested a review from alyssais as a code owner Aug 31, 2019

@alyssais

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

@0x4A6F 0x4A6F force-pushed the 0x4A6F:master-tacacs+ branch 2 times, most recently from 460b6fe to aeec3d9 Sep 1, 2019

pkgs/servers/tacacs+/default.nix Outdated Show resolved Hide resolved

@0x4A6F 0x4A6F force-pushed the 0x4A6F:master-tacacs+ branch from aeec3d9 to b1bf3a8 Sep 1, 2019

@aanderse
Copy link
Contributor

left a comment

LGTM 👍

@aanderse

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

@GrahamcOfBorg build tacacs+

@adisbladis adisbladis merged commit 8c76f18 into NixOS:master Sep 1, 2019

13 of 16 checks passed

tacacs+ on aarch64-linux
Details
tacacs+ on x86_64-darwin
Details
tacacs+ on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@0x4A6F 0x4A6F deleted the 0x4A6F:master-tacacs+ branch Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.