Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cordless: init at 2019-06-13 #64609

Closed
wants to merge 1 commit into from
Closed

cordless: init at 2019-06-13 #64609

wants to merge 1 commit into from

Conversation

@Bios-Marcel
Copy link

Bios-Marcel commented Jul 10, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

'';
homepage = https://www.github.com/Bios-Marcel/cordless;
license = licenses.bsd3;
maintainers = [ "Marcel Schramm <marceloschr@googlemail.com>" ];

This comment has been minimized.

@mmahut

mmahut Jul 11, 2019 Member

Do you mind moving this to maintainers/maintainer-list.nix?

This comment has been minimized.

@Bios-Marcel

Bios-Marcel Jul 11, 2019 Author

Sure, will do

name = "cordless-${version}";
version = "2019-06-13";

src = fetchurl {

This comment has been minimized.

@mmahut

mmahut Jul 11, 2019 Member

Please use fetchFromGitHub.

This comment has been minimized.

@Bios-Marcel

Bios-Marcel Jul 11, 2019 Author

Sure, but may I ask why that's better?

This comment has been minimized.

@aanderse

aanderse Jul 11, 2019 Contributor

fetchFromGitHub is better to use when you don't rely on a release tarball because nix can do some sort of caching that it can't with fetchurl.

This comment has been minimized.

@Bios-Marcel

Bios-Marcel Jul 11, 2019 Author

Ah I see, so it caches parts that are the same instead of the whole tarball, which would be useless.

@mmahut
Copy link
Member

mmahut commented Jul 11, 2019

@GrahamcOfBorg build cordless

@Bios-Marcel
Copy link
Author

Bios-Marcel commented Jul 11, 2019

After applying the requested changes I am getting this:

hash mismatch in fixed-output derivation '/nix/store/7lzy5cjv73rf7prk7y112hcym5625lj8-source':
  wanted: sha256:0rh58mynxka119g5g5mmz19ffisvj0y7ivc168kaaxbw3fr4v77g
  got:    sha256:1l2ajzqiw2pg2fn37wc4w7x0bswzig2xs9f0xmxxil57m7waf3wg

However, none of those hashsums appears in my file. What am I doing wrong herre?

Here is what I got so far:

{ stdenv, buildGoModule, fetchFromGitHub }:

buildGoModule rec {
  pname = "cordless";
  version = "2019-06-13";

  src = fetchFromGitHub {
    owner = "Bios-Marcel";
    repo = pname;
    rev = version;
    sha256 = "ef9c4db21b7c75a5263281ed783c905b47e752f8b596575e0a41cd6e7d450566";
  };

  doCheck = true;

  modSha256 = "08a1dg4d7fjdy8w3sbri3ik8k7c1snpa0rzwinal6inzmdyancys";

  subPackages = [ "." ];

  meta = with stdenv.lib; {
    description = "A third party Discord client";
    longDescription = ''
      Cordless is a third party Discord client that runs on the
      commandline and aims to have a low memory footprint and
      bandwidth consumption.
    '';
    homepage = https://www.github.com/Bios-Marcel/cordless;
    license = licenses.bsd3;
    maintainers = [ maintainers.biosmarcel ];
    platforms = platforms.linux;
  };
}
@aaronjanse
Copy link
Member

aaronjanse commented Jul 23, 2019

I just tried building this. After changing modSha256 to 1mxjbqddb6w3hjdscm2fkxq9z4w9vi08lgwyrg7i1x558lr914b3, it installed for me.

Weird

@aanderse
Copy link
Contributor

aanderse commented Aug 31, 2019

ping (triage)

@L-as
Copy link
Contributor

L-as commented Dec 29, 2019

Anything blocking this other than the fetchFromGitHub thing?

@Bios-Marcel
Copy link
Author

Bios-Marcel commented Dec 29, 2019

Well, this is quite outdated either way. Should I just make a new PR?

@L-as
Copy link
Contributor

L-as commented Dec 29, 2019

I don't see the problem with updating this one. FWIW, it still works fine (though I updated the version, and changed it to fetchFromGitHub)

Copy link
Member

ryantm left a comment

Please address mmahut's change requests.

@stale
Copy link

stale bot commented Jul 1, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.
@stale stale bot added the 2.status: stale label Jul 1, 2020
@Bios-Marcel Bios-Marcel closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.