Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fasttext: 0.2.0 -> 0.9.1 #64639

Merged
merged 1 commit into from Jul 12, 2019

Conversation

Projects
None yet
3 participants
@danieldk
Copy link
Contributor

commented Jul 11, 2019

Motivation for this change

Changes:

  • Refactoring of internal classes.
  • Better unicode handling.

https://github.com/facebookresearch/fastText/releases/tag/v0.9.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

fasttext: 0.2.0 -> 0.9.1
Changes:

- Refactoring of internal classes.
- Better unicode handling.

https://github.com/facebookresearch/fastText/releases/tag/v0.9.1
@danieldk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@GrahamcOfBorg build fasttext

@jonringer
Copy link
Contributor

left a comment

since this looks like a repeat of your library, I think you could use toPythonApplication from the other derivation.

in pkgs/top-level/all-packages.nix

fasttext = callPackage ../applications/science/machine-learning/fasttext { };

to

fasttext = python3.pkgs.toPythonApplication python3.pkgs.fasttext;

or something similar, i might be off by a little in terms of syntax.

EDIT:
nevermind, looked at the file. They are in the same repo, but they are completely different builds.

@jonringer
Copy link
Contributor

left a comment

nix-review pr 64639 passes on NixOS
diff LGTM
binary works

$ nix path-info -Sh ./results/fasttext
/nix/store/a3n85z82jl2mxskd73gv6ky9w7s5qxgr-fasttext-0.9.1        34.1M
@teto

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Thanks for the package and to @jonringer for his reviews <3

@teto teto merged commit 3a4ba91 into NixOS:master Jul 12, 2019

15 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
fasttext on aarch64-linux Success
Details
fasttext on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.