Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.fasttext: 0.2.0 -> 0.9.1 #64640

Merged
merged 1 commit into from Jul 12, 2019

Conversation

Projects
None yet
4 participants
@danieldk
Copy link
Contributor

commented Jul 11, 2019

Motivation for this change

Changes:

https://github.com/facebookresearch/fastText/releases/tag/v0.9.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk requested a review from FRidh as a code owner Jul 11, 2019

@danieldk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@GrahamcOfBorg build pythonPackages.fasttext python3Packages.fasttext

@jonringer
Copy link
Contributor

left a comment

$ nix-review pr 64640 passes on NixOS
diff LGTM

[4 built, 8 copied (80.1 MiB), 11.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64640
2 package were build:
python27Packages.fasttext python37Packages.fasttext
@costrouc

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Nix review passed

Result of nix-review pr 64640 1

2 package were build:
  • python27Packages.fasttext
  • python37Packages.fasttext
@teto

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Thanks for the package and the reviews.

@teto teto merged commit f4ecf17 into NixOS:master Jul 12, 2019

15 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python3Packages.fasttext, pythonPackages.fasttext on aarch64-linux Success
Details
python3Packages.fasttext, pythonPackages.fasttext on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.