Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fribidi: fix cross compilation #64655

Merged
merged 2 commits into from Aug 3, 2019

Conversation

@tadeokondrak
Copy link
Member

commented Jul 12, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tadeokondrak tadeokondrak force-pushed the tadeokondrak:fribidi/fix-cross branch from 4b245e1 to a52fa80 Jul 12, 2019

@tadeokondrak tadeokondrak changed the base branch from master to staging Jul 12, 2019

@tadeokondrak

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

Hard to switch the target branch of a PR without causing review noise, sorry :/

@worldofpeace worldofpeace removed the request for review from FRidh Jul 13, 2019


meta = with stdenv.lib; {
homepage = https://github.com/fribidi/fribidi;
homepage = "https://github.com/fribidi/fribidi";

This comment has been minimized.

Copy link
@FRidh

FRidh Jul 17, 2019

Member

Unnecessary change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.