Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spago: init at 0.8.5.0 #64704

Closed
wants to merge 1 commit into from
Closed

spago: init at 0.8.5.0 #64704

wants to merge 1 commit into from

Conversation

@Shou
Copy link
Contributor

Shou commented Jul 13, 2019

Credit to justinwoo/easy-purescript-nix.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

alexarice left a comment

The github page suggests installing this through npm. Would the existing node tools be a better way of installing this

pkgs/development/web/spago/default.nix Outdated Show resolved Hide resolved
pkgs/development/web/spago/default.nix Outdated Show resolved Hide resolved
sha256 = "0r66pmjfwv89c1h71s95nkq9hgbk7b8h9sk05bfmhsx2gprnd3bq";
};

buildInputs = [ pkgs.gmp pkgs.zlib pkgs.ncurses5 pkgs.stdenv.cc.cc.lib ];

This comment has been minimized.

Copy link
@alexarice

alexarice Jul 13, 2019

Contributor

unsure about the c compiler library package, perhaps this should be a native build input?

This comment has been minimized.

Copy link
@Shou

Shou Jul 15, 2019

Author Contributor

I've done this now.

Credit to [justinwoo/easy-purescript-nix][1].

[1]: https://github.com/justinwoo/easy-purescript-nix
@Shou Shou force-pushed the Shou:init-spago branch from b26a37f to df32807 Jul 15, 2019
@cdepillabout
Copy link
Member

cdepillabout commented Dec 5, 2019

I packaged spago in #74557.

However, this builds it from source and doesn't use the easy-purescript-nix approach.

If spago built from source breaks frequently, it might make sense to go back and use the easy-purescript-nix approach.

@Shou
Copy link
Contributor Author

Shou commented Mar 7, 2020

(I'm late but I'll close this now given the above)

@Shou Shou closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.