Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pantheon.cerbere: 0.2.4 -> 2.5.0 #64707

Merged
merged 1 commit into from Aug 3, 2019

Conversation

@worldofpeace
Copy link
Member

commented Jul 13, 2019

Fixes #60955

Motivation for this change

Upstream should have fixes for #60955 but it seemed like it was still timing out on my
system so I've opened this for feedback. If it's the case that it's not actually fixed I should
be able to re-open the issue upstream.

https://github.com/elementary/cerbere/releases/tag/2.5.0

  • Handle SIGHUP and SIGTERM to prevent hang on system shutdown
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

cc @davidak.

I'm not sure if this actually was fixing the issue #60955.
Though perhaps other programs in pantheon need fixes like this.

@davidak

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

I build my system with this branch and it fixes the problem. Shutdown takes now about 2 seconds. It took very long before. I had no program open.

The test system is this: https://github.com/davidak/nixos-config/blob/master/machines/imac/configuration.nix (using systemd-boot)

@davidak
davidak approved these changes Aug 2, 2019
Copy link
Member

left a comment

It fixes the problem for me. Change also looks sane.

@worldofpeace

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

Thank you @davidak

I currently lack testers for Pantheon (I've been pushing things that I've only manually tested)
so it would be a great help to continue this if you'd like.

@worldofpeace worldofpeace merged commit f8de228 into NixOS:master Aug 3, 2019

15 of 16 checks passed

pantheon.cerbere on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pantheon.cerbere on aarch64-linux Success
Details
pantheon.cerbere on x86_64-linux Success
Details

Pantheon automation moved this from In progress to Done Aug 3, 2019

@worldofpeace worldofpeace deleted the worldofpeace:cerbere-fix branch Aug 3, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

backported in 4f2b76e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.