Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matomo: 3.9.1 -> 3.10.0 #64848

Merged
merged 2 commits into from Aug 3, 2019

Conversation

@jonringer
Copy link
Contributor

commented Jul 15, 2019

Motivation for this change

Was doing a review of #64839 and noticed the binary would just throw a runtime error, this is to fix it not being able to find a config file.

before
$ ./result/bin/matomo-console

Warning: require(/nix/store/rppa93chjkiikyx75hbb53b67vhsc9vb-matomo-3.9.1/share/config/global.php): failed to open stream: No such file or directory in /nix/store/rppa93chjkiikyx75hbb53b67vhsc9vb-matomo-3.9.1/share/vendor/php-di/php-di/src/DI/Definition/Source/DefinitionFile.php on line 56

Fatal error: require(): Failed opening required '/nix/store/rppa93chjkiikyx75hbb53b67vhsc9vb-matomo-3.9.1/share/config/global.php' (include_path='/nix/store/rppa93chjkiikyx75hbb53b67vhsc9vb-matomo-3.9.1/share/vendor/pear/pear_exception:/nix/store/rppa93chjkiikyx75hbb53b67vhsc9vb-matomo-3.9.1/share/vendor/pear/console_getopt:/nix/store/rppa93chjkiikyx75hbb53b67vhsc9vb-matomo-3.9.1/share/vendor/pear/pear-core-minimal/src:/nix/store/rppa93chjkiikyx75hbb53b67vhsc9vb-matomo-3.9.1/share/vendor/pear/archive_tar:.:/nix/store/hvh94cgh6ppcyf244gf4f9pm9fli8zk0-php-7.3.7/lib/php') in /nix/store/rppa93chjkiikyx75hbb53b67vhsc9vb-matomo-3.9.1/share/vendor/php-di/php-di/src/DI/Definition/Source/DefinitionFile.php on line 56
after
$ ./result/bin/matomo-console

The configuration file {/nix/store/kjb2s0fr0m8fm8ic169zg0gqcrchfip3-matomo-3.10.0/share/config/config.ini.php} has not been found or could not be read.
 » Please check that /nix/store/kjb2s0fr0m8fm8ic169zg0gqcrchfip3-matomo-3.10.0/share/config/config.ini.php is readable by the user 'jon'.


Matomo version 3.10.0

Usage:
 command [options] [arguments]

Options:
 --help (-h)           Display this help message
 --quiet (-q)          Do not output any message
 --verbose (-v|vv|vvv) Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug
 --version (-V)        Display this application version
 --ansi                Force ANSI output
 --no-ansi             Disable ANSI output
 --no-interaction (-n) Do not ask any interactive question
 --matomo-domain       Matomo URL (protocol and domain) eg. "http://matomo.example.org"
 --piwik-domain        [DEPRECATED] Matomo URL (protocol and domain) eg. "http://matomo.example.org"
 --xhprof              Enable profiling with XHProf
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @florianjacob as you seem to be the original maintainer

@aanderse

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

@mmahut Did you run into any of the issues @jonringer had when executing binaries?

@nixos-discourse

This comment has been minimized.

Copy link

commented Jul 31, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/33

@teto teto merged commit dc5584a into NixOS:master Aug 3, 2019

15 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
matomo on aarch64-linux Success
Details
matomo on x86_64-linux Success
Details

@jonringer jonringer deleted the jonringer:fix-matomo branch Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.