Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages: update #65043

Merged
merged 122 commits into from Aug 3, 2019

Conversation

@volth
Copy link
Contributor

commented Jul 18, 2019

Update perlPackages to the latest CPAN versions
Fixes #48857
Fixes #62278
Fixes #63230
Fixes #64137

@aanderse @rycee

@jonringer

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

buildilng of hydra fails for me

Fail log
$ git log --oneline | head -n5 # just to show im oim on the right branch
5e2e9764248 perlPackages.AppClusterSSH: init at 4.13.2
9fad02b798a [cpan2nix] perlPackages.DeviceSerialPort: init at 1.04
b24496a3492 [cpan2nix] perlPackages.DistZillaPluginTestMinimumVersion: 2.000008 -> 2.000010
b8e6ffb1547 [cpan2nix] perlPackages.CatalystViewJSON: 0.36 -> 0.37
b3e67a31057 [cpan2nix] perlPackages.TaskFreecellSolverTesting: cleanup

$ nix-build default.nix -A hydra --cores 1 --show-trace
...
Cases: 15  Tried: 6  Errors: 0  Failures: 0  creating: test-zip-archive.-6e79b56754d3fb92/dir1
  creating: test-zip-archive.-6e79b56754d3fb92/dir1/dir2
 inflating: test-zip-archive.-6e79b56754d3fb92/dir1/dir2/hello
extracting: test-zip-archive.-6e79b56754d3fb92/dir1/hi
Cases: 15  Tried: 11  Errors: 0  Failures: 0  creating: test-zip-archive.-6e79b56754d3fb92/dir3
extracting: test-zip-archive.-6e79b56754d3fb92/dir3/hi
Cases: 15  Tried: 14  Errors: 0  Failures: 0Archive:  ./test-zip-archive.-6e79b56754d3fb92/testUnzip.zip
   creating: test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks4/
   creating: test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks4/1/
 extracting: test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks4/1/file.txt
error: invalid zip file with overlapped components (possible zip bomb)
### Failure in: 14
tests/test-zip-archive.hs:273
unzip succeeds
Cases: 15  Tried: 15  Errors: 0  Failures: 1
test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks2/
test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks2/1/
test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks2/1/file.txt
test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks2/link_to_file
test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks2/link_to_directory
test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks2/link_to_directory/file.txt
test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks2/
test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks2/1/
test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks2/1/file.txt
test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks2/link_to_file
test-zip-archive.-6e79b56754d3fb92/test_dir_with_symlinks2/link_to_directory
Test suite test-zip-archive: FAIL
Test suite logged to: dist/test/zip-archive-0.4.1-test-zip-archive.log
0 of 1 test suites (0 of 1 test cases) passed.
checking for struct utmpx.ut_syslen... no
builder for '/nix/store/c09c5b30vn3941cv0gkvn7s17ksy4453-zip-archive-0.4.1.drv' failed with exit code 1
cannot build derivation '/nix/store/mb3c4rakfqgb9n44kbvgbsjxbymr3vfi-darcs-2.14.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0prm7lz5nvcpdm24q9qryr59d9d0v2q5-nix-build.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0prm7lz5nvcpdm24q9qryr59d9d0v2q5-nix-build.drv' failed
@volth

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

buildilng of hydra fails for me

The same before this PR

nix-build --option binary-caches http://cache.nixos.org/ \
  -E "(import (builtins.fetchTarball https://github.com/NixOS/nixpkgs/archive/staging.tar.gz) { }).hydra"

It is something broken in haskellPackages, not perlPackages.
Very likely a regression after #64909

@rycee
rycee approved these changes Jul 20, 2019
Copy link
Member

left a comment

Browsed through the changes and it all looks good to me. Didn't do any deeper tests but I think it is fine to merge to staging.

@volth

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2019

@peti
could you please s/gdk_pixbuf/gdk-pixbuf/g in the script which generates "hackage-packages.nix" ?
ofborg fails: https://gist.github.com/GrahamcOfBorg/a82c866c1ea14360edaa8f72276238d8

@peti

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

@volth, this has been done in NixOS/cabal2nix#424 already. Note that I don't re-generate anything in staging. I target only master.

@volth

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

master is not yet regenerated (https://github.com/NixOS/nixpkgs/commits/master/pkgs/development/haskell-modules/hackage-packages.nix)
ok, let's wait update of master and its merge to staging

@FRidh

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

please rebase

@peti

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

@volth,

ok, let's wait update of master and its merge to staging

I cannot re-generate master until staging has been merged because that update would break all code that depends on gdk-pixbuf (which does not exist in master).

@volth volth closed this Jul 28, 2019

@volth

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

It seems fixed on staging: 360e687

@volth volth reopened this Jul 31, 2019

volth added 14 commits Jul 2, 2019
[cpan2nix] perlPackages.Catmandu: init at 1.2002
dependencies:
perlPackages.AnyURIEscape: init at 0.01
perlPackages.ConfigOnion: init at 1.007
perlPackages.DataUtil: init at 0.66
perlPackages.DispatchClass: init at 0.02
perlPackages.LogAnyAdapterLog4perl: init at 0.09
perlPackages.MooXAliases: init at 0.001006
perlPackages.ParserMGC: init at 0.16
perlPackages.PathIteratorRule: init at 1.014
perlPackages.TestFilename: init at 0.03
perlPackages.TestLWPUserAgent: init at 0.033
perlPackages.TextHogan: init at 2.02
perlPackages.TryTinyByClass: init at 0.01
perlPackages.URITemplate: init at 0.24
[cpan2nix] perlPackages.CatalystPluginSmartURI: init at 0.041
dependencies:
perlPackages.TimeOut: init at 0.11
perlPackages.URISmartURI: init at 0.032

@volth volth force-pushed the volth:cpan2nix-2019-07-18 branch from f032b61 to b434ee6 Jul 31, 2019

@aanderse
Copy link
Contributor

left a comment

@volth Thanks for all your hard work every time!

@aanderse

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

@jonringer @peti Any outstanding issues preventing a merge to staging or should we pull the trigger?

@FRidh FRidh merged commit 5e32d10 into NixOS:staging Aug 3, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@volth volth referenced this pull request Aug 9, 2019
4 of 9 tasks complete
@herrwiese herrwiese referenced this pull request Aug 27, 2019
3 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.