Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven: Wrap mvnDebug for convenience #65278

Closed
wants to merge 1 commit into from
Closed

Conversation

@bessonm
Copy link
Contributor

@bessonm bessonm commented Jul 22, 2019

Since maven 2.0.8, it is shipped with a debugger, mvnDebug, which is sometimes useful.
Wrapping it is more convenient for use, instead of looking for it in the nix store.

Things done
  • Built on :

    • NixOS
    • macOS
  • Tested :

  • Tested using nix-env -f ~/sources/nixpkgs/ -iA maven, then calling mvnDebug.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)

  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

@edibopp
Copy link
Contributor

@edibopp edibopp commented May 15, 2020

Looks like nobody paid attention to this PR. @bessonm, I know it's been a long time. By now, there is a trivial merge conflict to resolve. Would you mind rebasing this onto current master?

@bessonm bessonm mentioned this pull request May 15, 2020
3 of 10 tasks complete
@bessonm
Copy link
Contributor Author

@bessonm bessonm commented May 15, 2020

Sorry,
Since I deleted my fork some weeks ago I had to create another PR, see :
#87894

@bessonm bessonm closed this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.