Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

barrier: 2.1.1 -> 2.2.0 #65293

Merged
merged 1 commit into from Jul 23, 2019
Merged

barrier: 2.1.1 -> 2.2.0 #65293

merged 1 commit into from Jul 23, 2019

Conversation

@ar1a
Copy link
Contributor

ar1a commented Jul 23, 2019

Motivation for this change

New update, and also it won't launch ( see #65292 )

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) (906.4M -> 930.0M)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

worldofpeace left a comment

Review FTW 🎊

pkgs/applications/misc/barrier/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/barrier/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/barrier/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/barrier/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/barrier/default.nix Outdated Show resolved Hide resolved
Copy link
Member

worldofpeace left a comment

Built and executed successfully ✔️

I trust you've tested that it works for your purposes.

@ar1a

This comment has been minimized.

Copy link
Contributor Author

ar1a commented Jul 23, 2019

yep, good to squash?

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jul 23, 2019

yep 👍

fixes #65292
@ar1a ar1a force-pushed the ar1a:barrier branch from 3e4cef7 to 8d6f00a Jul 23, 2019
@ar1a

This comment has been minimized.

Copy link
Contributor Author

ar1a commented Jul 23, 2019

all done

@worldofpeace worldofpeace merged commit f99063f into NixOS:master Jul 23, 2019
1 check was pending
1 check was pending
grahamcofborg-eval Checking original out paths
Details
@ar1a ar1a deleted the ar1a:barrier branch Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.