Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbarrier: 2.1.1 -> 2.2.0 #65293
Merged
barrier: 2.1.1 -> 2.2.0 #65293
Conversation
|
Review FTW |
|
Built and executed successfully I trust you've tested that it works for your purposes. |
This comment has been minimized.
This comment has been minimized.
|
yep, good to squash? |
This comment has been minimized.
This comment has been minimized.
|
yep |
This comment has been minimized.
This comment has been minimized.
|
all done |
f99063f
into
NixOS:master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ar1a commentedJul 23, 2019
•
edited
Motivation for this change
New update, and also it won't launch ( see #65292 )
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after) (906.4M -> 930.0M)