Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildGoModule: Add bazaar support #65320

Closed
wants to merge 2 commits into from
Closed

buildGoModule: Add bazaar support #65320

wants to merge 2 commits into from

Conversation

@trcm
Copy link

trcm commented Jul 24, 2019

Motivation for this change

I had some failing build for go modules due to the dependencies using bazaar rather than git.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@trcm trcm changed the title Add bazaar support to buildGoModule buildGoModule: Add bazaar support Jul 24, 2019
@worldofpeace worldofpeace requested a review from kalbasit Jul 31, 2019
@worldofpeace
Copy link
Member

worldofpeace commented Jul 31, 2019

I've requested @kalbasit to review your PR @trcm because he maintains this framework.

Other than that, please merge instead of rebasing per the contribution guidelines
and we need to resolve the conflicts.

runCommandNoCC "bzr-no-cert-validation" {
inherit bazaar;
buildInputs = [ makeWrapper ];
} "makeWrapper $bazaar/bin/bzr $out/bin/bzr --add-flags -Ossl.cert_reqs=none";

This comment has been minimized.

@kalbasit

kalbasit Jul 31, 2019 Member

Is there a way to provide the cacert instead of disabling TLS altogether?

@Infinisil
Copy link
Member

Infinisil commented Jan 15, 2020

What's the status of this?

@kalbasit
Copy link
Member

kalbasit commented Jan 16, 2020

I'd say it's stalled. @trcm are you interested in getting this off to the finish line?

@trcm
Copy link
Author

trcm commented Jan 16, 2020

Yeah sorry, I'll circle back around and have a look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.