Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrains.*: 2019.1.3 -> 2019.2 (mostly); jetbrainsjdk: 11.0.2b164 -> 11.0.3b360.2 #65383

Closed
wants to merge 11 commits into from

Conversation

@jdanekrh
Copy link
Member

jdanekrh commented Jul 25, 2019

Motivation for this change

New major release of the IDE suite. I had issue with the older jdk, so I upgraded that also, which resolved it.

Things done

I've tested idea-ultimate, clion, and rider, I do not use the other IDEs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jdanekrh

This comment has been minimized.

Copy link
Member Author

jdanekrh commented Jul 26, 2019

So, building jetbrains.webstorm fails, others succeed

builder for '/nix/store/b1vwv58y4x4f80b616b8yn27jx21nj5x-webstorm-2019.2.drv' failed with exit code 1; last 6 log lines:
  unpacking sources
  unpacking source archive /nix/store/hb4ljqxfps1cgwj4shwrla3w9y7agwg0-WebStorm-2019.2.tar.gz
  source root is WebStorm-192.5728.87
  setting SOURCE_DATE_EPOCH to timestamp 1563790706 of file WebStorm-192.5728.87/product-info.json
  patching sources
  rm: cannot remove 'jre64': No such file or directory
@jdanekrh

This comment has been minimized.

Copy link
Member Author

jdanekrh commented Jul 26, 2019

jetbrains.webstorm now builds and starts as well

@averelld

This comment has been minimized.

Copy link
Contributor

averelld commented Jul 26, 2019

GoLand was updated to 2019.2 meanwhile too.

@jdanekrh jdanekrh force-pushed the jdanekrh:jb_2019.2 branch from 2f8b25c to 999b322 Jul 26, 2019
Copy link
Member

angristan left a comment

Tested with nix-review. Everything builds and each IDE starts correctly. ✔️

@jdanekrh jdanekrh force-pushed the jdanekrh:jb_2019.2 branch from 999b322 to b767e1b Aug 3, 2019
@jdanekrh

This comment has been minimized.

Copy link
Member Author

jdanekrh commented Aug 3, 2019

/cc maintainers @Mic92 @loskutov @miltador @baldo

@jdanekrh

This comment has been minimized.

Copy link
Member Author

jdanekrh commented Aug 3, 2019

Updates for datagrip and ruby-mine which were meanwhile released are in #65837. As a further improvement for another PR, I am thinking of removing the jbr directory from all jetbrains tools, not just webstorm. It will save ~130 MB for each package where it is now uselessly present.

@jdanekrh jdanekrh force-pushed the jdanekrh:jb_2019.2 branch from b767e1b to 6f1de57 Aug 3, 2019
@jdanekrh

This comment has been minimized.

Copy link
Member Author

jdanekrh commented Aug 10, 2019

Rider 2019.2 is in #66426

@DavidDudson DavidDudson mentioned this pull request Aug 28, 2019
3 of 10 tasks complete
@eadwu eadwu mentioned this pull request Aug 29, 2019
3 of 10 tasks complete
@c0bw3b

This comment has been minimized.

Copy link
Contributor

c0bw3b commented Dec 1, 2019

Obsolete, there is now newer versions in nixpkgs

@c0bw3b c0bw3b closed this Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.