Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-fast-syntax-highlighting:init at 1.54 #65429

Merged
merged 2 commits into from Nov 20, 2019
Merged

zsh-fast-syntax-highlighting:init at 1.54 #65429

merged 2 commits into from Nov 20, 2019

Conversation

@pasqui23
Copy link
Contributor

pasqui23 commented Jul 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Nov 9, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/67

@timokau

This comment has been minimized.

Copy link
Member

timokau commented Nov 9, 2019

Thank you for your contribution, but please keep "PRs already reviewed" to only those PRs that have actually been reviewed ;)

@pasqui23 pasqui23 changed the title zsh-fast-syntax-highlighting:init at 2019-07-20 zsh-fast-syntax-highlighting:init at 15.4 Nov 19, 2019
@pasqui23 pasqui23 changed the title zsh-fast-syntax-highlighting:init at 15.4 zsh-fast-syntax-highlighting:init at 1.54 Nov 19, 2019
Copy link
Contributor

jonringer left a comment

please squash all commits:

git reset HEAD~6
git add pkgs/
git commit --amend --no-edit
git push --force <fork> <branch>
@pasqui23 pasqui23 force-pushed the pasqui23:fsyh branch from 374623d to d0481d0 Nov 19, 2019
@veprbl veprbl self-assigned this Nov 20, 2019
@veprbl veprbl dismissed alyssais’s stale review Nov 20, 2019

addressed

@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Nov 20, 2019

@GrahamcOfBorg build zsh-fast-syntax-highlighting

@veprbl

This comment has been minimized.

Copy link
Member

veprbl commented Nov 20, 2019

@pasqui23 I took liberty to further simplify the expression. The "cd $src" line is actually not needed after unpackPhase creates a copy of the source code and harmful in cases when user tries to add patches or override src to point to a tarball. Also "install -m644" doesn't do anything for us, the write bit will be reset by Nix for files in the store. An "install -m444" would be fine, but we are already doing "cp" on some directories, so we might as well stick with it.

@veprbl
veprbl approved these changes Nov 20, 2019
Copy link
Member

veprbl left a comment

Tested on NixOS, highlighting works.

@veprbl veprbl merged commit c20f765 into NixOS:master Nov 20, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
zsh-fast-syntax-highlighting on aarch64-linux Success
Details
zsh-fast-syntax-highlighting on x86_64-darwin Success
Details
zsh-fast-syntax-highlighting on x86_64-linux Success
Details
@veprbl veprbl removed their assignment Nov 23, 2019
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 18, 2020
(cherry picked from commit c20f765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.