Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sogo: Init at 4.0.8 #65530

Closed
wants to merge 1 commit into from
Closed

sogo: Init at 4.0.8 #65530

wants to merge 1 commit into from

Conversation

@dasJ
Copy link
Member

@dasJ dasJ commented Jul 28, 2019

I know this isn't the most beautiful code, but gnustep doesn't really
like the way nix handles the dependencies and would rather write every
library and binary to the same directory.

Motivation for this change

I also have a module for this, but that's for a later PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I know this isn't the most beautiful code, but gnustep doesn't really
like the way nix handles the dependencies and would rather write every
library and binary to the same directory.
@@ -13365,6 +13366,8 @@ in

sonic = callPackage ../development/libraries/sonic { };

sope = pkgs.callPackage ../development/libraries/sope { };

This comment has been minimized.

@mmahut

mmahut Aug 9, 2019
Member

Can you make one commit per new package please?

@mmahut
Copy link
Member

@mmahut mmahut commented Aug 9, 2019

@GrahamcOfBorg build sogo sope

@ajs124 ajs124 mentioned this pull request Feb 3, 2020
0 of 10 tasks complete
@dasJ dasJ closed this Feb 5, 2020
@dasJ dasJ deleted the dasJ:init-sogo branch Feb 5, 2020
@dasJ
Copy link
Member Author

@dasJ dasJ commented Feb 5, 2020

See #79175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.