Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hcloud: 1.11.0 -> 1.13.0 #65599

Merged
merged 2 commits into from Aug 3, 2019

Conversation

@zauberpony
Copy link
Contributor

commented Jul 30, 2019

Motivation for this change

Update hcloud v1.11.0 to v1.13.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@petabyteboy already created a PR for 1.11.0 -> 1.12.0 which did not yet get merged, but is somehow superseeded by the update to 1.13.0

@petabyteboy

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

Built and ran resulting binary 👍
Closure size increased from 38.9M to 39.3M, which seems fine for this update

@petabyteboy

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

If you like you can add quotes to the homepage (NixOS/rfcs#45) and change name = "hcloud-${version}"; to pname = "hcloud"; (NixOS/rfcs#35).

hcloud: utilize pname and quote URL
This implements rfc 0035 and rfc 0045.
@zauberpony

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

Ah great, I didn't know about these, thanks for the info! I implemented the changes you proposed :)

@angristan
Copy link
Member

left a comment

Successful build and run:

[nix-shell:~/.cache/nix-review/pr-65599]$ hcloud version
hcloud 1.13.0

@srhb srhb merged commit 33c3c22 into NixOS:master Aug 3, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.