Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptables: CVE-2019-11360 (release-19.03) #65662

Closed
wants to merge 1 commit into from

Conversation

@mmahut
Copy link
Member

commented Jul 31, 2019

Motivation for this change

Fixes #65647.

We need to discuss whatever back-porting this makes sense at this severity.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz

@ofborg ofborg bot requested a review from fpletz Jul 31, 2019

@FRidh FRidh changed the base branch from release-19.03 to staging-19.03 Aug 3, 2019

@FRidh FRidh changed the base branch from staging-19.03 to release-19.03 Aug 3, 2019

@FRidh

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Pushed bf9684327735cb6841623849806fcdb91ae9b9a3 to staging-19.03.

@vcunat

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

@FRidh: I can't see anything like this pushed.

vcunat added a commit that referenced this pull request Aug 3, 2019
@vcunat

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Anyway, let me push it before forgetting again: fe419b6

@FRidh

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Good you've noticed this, thanks!

@vcunat

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

:-) It tipped me off that GitHub didn't linkify the hash (in my e-mail, too).

rycee added a commit to rycee/nixpkgs that referenced this pull request Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.