Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gitlab to 12.1 #65663

Closed
wants to merge 2 commits into from

Conversation

@bgamari
Copy link
Contributor

commented Jul 31, 2019

Motivation for this change

Update GitLab to 12.1.2. Also fix an issue where the nixos module failed to start as it tried to delete the hooks directories with non-recursive rm.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz @globin @roblabla

bgamari added some commits Jul 30, 2019

@srhb
Copy link
Contributor

left a comment

Looks like this or some earlier change broke the test. It's hard to tell, because apparently there's some other, earlier breakage currently in master as well. Investigating..

@srhb

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

Looks like the tests were broken in #64550 already.

@srhb

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

I've opened #65681 for the tests instead.

@flokli

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

This should be covered by #66621, I cherry-picked
0e6b805 into it aswell. Thanks!

@flokli flokli closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.