Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

framac: 18.0 -> 19.0 #65664

Closed
wants to merge 1 commit into from

Conversation

@yrashk
Copy link
Contributor

commented Jul 31, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @amiddelk

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@GrahamcOfBorg build framac

@thoughtpolice
Copy link
Member

left a comment

This is already done by #63494, which also does more, including auto-configuration of why3 provers, and does several other nice cleanups. It was WIP until a few days ago, as the author was otherwise busy, I assume.

Apologies for taking a few days to reply to this; however I think #63494 is probably what we want to merge in the end.

@vbgl

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

Closing as #63494 has been merged.

@vbgl vbgl closed this Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.