Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: enable `__structuredAttrs` in `stdenv.mkDerivation` #65686

Closed
wants to merge 1 commit into from

Conversation

@FRidh
Copy link
Member

commented Jul 31, 2019

This is an attempt at adding support for __structuredAttrs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh FRidh force-pushed the FRidh:attrs branch 2 times, most recently from 29793f6 to ec448e9 Jul 31, 2019

WIP: enable `__structuredAttrs` in `stdenv.mkDerivation`
This is an attempt at adding support for `__structuredAttrs`.

@FRidh FRidh force-pushed the FRidh:attrs branch from ec448e9 to e9516da Jul 31, 2019

@ofborg ofborg bot added the 6.topic: stdenv label Jul 31, 2019

@FRidh

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

While .attrs.sh is bash-compatible, the declared attributes are different than what existed. E.g., the output $out is now ${outputs["out"]}. I suppose for compatibility we should ensure the original variables still function.

@globin

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@FRidh

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

oh, nice! It certainly seems there is still a lot of work required. Is Mayflower going with this any further?

@globin

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

I don't have time to progress further for now. Building stdenv partly suceeds to build in my branch, in the sense that as far as I can see the only problem is that I have a problem with input ordering or similar so that the bootstrap tools are referenced instead of stuff built during stdenv bootstrapping. but didn't manage to debug that further until now.

I know @matthewbauer, @Ericson2314 and @edolstra at least were interested in this too.

@globin

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Furthermore I'd propose pushing my branch to NixOS/nixpkgs and create a follow-up PR so that a larger number of people can work on this concurrently? Feel free to just go ahead and do so if you think that should be the way to move forward on this.

@FRidh FRidh closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.