Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox-beta-bin-unwrapped, firefox-devedition-bin-unwrapped: 68.0b12 -> 69.0b10 #65807

Merged
merged 2 commits into from Aug 3, 2019

Conversation

@flatulation
Copy link
Contributor

commented Aug 2, 2019

Motivation for this change

The version of firefox-beta and firefox-devedition in master is a major version behind upstream.

Things done
$ nix-shell maintainers/scripts/update.nix --argstr package firefox-beta-bin-unwrapped
$ nix-shell maintainers/scripts/update.nix --argstr package firefox-devedition-bin-unwrapped

update.nix gave me a GPG error checked out at b978a94 so what I did was checkout master, run update.nix, stash the new sources and then unstash them in the fix branch.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@flatulation flatulation force-pushed the flatulation:fix/firefox-bin-update branch from 6733edf to e8ab003 Aug 2, 2019

@flatulation flatulation changed the base branch from release-19.03 to master Aug 2, 2019

@flatulation

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

@flatulation flatulation changed the title Fix/firefox bin update firefox-beta-bin-unwrapped, firefox-devedition-bin-unwrapped: 68.0b12 -> 69.0b10 Aug 2, 2019

@flatulation flatulation marked this pull request as ready for review Aug 2, 2019

@grahamc grahamc merged commit 58f5c8e into NixOS:master Aug 3, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.