Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shotcut: use qt's mkDerivation #65818

Closed
wants to merge 1 commit into from

Conversation

@grahamc
Copy link
Member

commented Aug 2, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@grahamc

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

cc #65399

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Lol, already duplicated @grahamc #65785

Maybe pretend it's a race?

@grahamc

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

goodness gracious we are great

@grahamc grahamc closed this Aug 3, 2019

@grahamc grahamc deleted the grahamc:shotcut branch Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.