Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solaar: unstable -> 1.0.1 #65847

Open
wants to merge 1 commit into
base: master
from

Conversation

@ysndr
Copy link
Contributor

commented Aug 3, 2019

Motivation for this change

Keep track with the releases that were continued to be issued by the solaar devs and contain the recent development.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ysndr

@ysndr

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@spinus Do you need to have a look at this?

@spinus
spinus approved these changes Aug 14, 2019
Copy link
Member

left a comment

looks good, thank you for taking care of this @ysndr !

@spinus

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

@ysndr actually I spot small issue, but it was not in the change so I didn't spot at first. Could you update homepage as well?

@spinus

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

and potentially commit description should match pattern when you upgrade version. https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

@ysndr ysndr changed the title solaar: track latest release and set correct repo owner solaar: unstable -> 1.0.1 Aug 14, 2019

@ysndr

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Could you update homepage as well?
Yeah totally missed that as well

@spinus
spinus approved these changes Aug 15, 2019
@spinus

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

good stuff, cheers

@bjornfor

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2019

This needs a rebase.

@ysndr ysndr force-pushed the ysndr:update/solaar branch from 46a8745 to 423512b Sep 16, 2019

@ysndr ysndr force-pushed the ysndr:update/solaar branch from 423512b to 2081dde Sep 16, 2019

solaar: track latest release and set correct repo owner
Update project homepage

Drop 'unstable' package name attribute

@ysndr ysndr force-pushed the ysndr:update/solaar branch from 2081dde to 128b839 Sep 16, 2019

@ysndr

This comment has been minimized.

Copy link
Contributor Author

commented Sep 16, 2019

so finally after struggling with getting my local fork up to date I guess this will work now
@bjornfor / @spinus who is responsible for getting this merged?

@ofborg ofborg bot requested a review from spinus Sep 16, 2019

@spinus

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

@ysndr I have no merge writes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.