Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-cbindgen: 0.8.7 -> 0.9.0 #65856

Merged
merged 1 commit into from Aug 31, 2019

Conversation

@jonringer
Copy link
Contributor

commented Aug 3, 2019

Motivation for this change

fixing packages that failed to build in rryantm logs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jtojnar @andir

@teto

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

thanks a nix-review on this failed with:

  warning: build failed, waiting for other jobs to finish...
  error: build failed
  make[3]: *** [/build/firefox-68.0.1/config/makefiles/rust.mk:240: force-cargo-library-build] Error 101
  make[3]: Leaving directory '/build/firefox-68.0.1/obj-x86_64-pc-linux-gnu/toolkit/library/rust'
  make[2]: *** [/build/firefox-68.0.1/config/recurse.mk:74: toolkit/library/rust/target] Error 2
  make[2]: Leaving directory '/build/firefox-68.0.1/obj-x86_64-pc-linux-gnu'
  make[1]: *** [/build/firefox-68.0.1/config/recurse.mk:34: compile] Error 2
  make[1]: Leaving directory '/build/firefox-68.0.1/obj-x86_64-pc-linux-gnu'
  make: *** [/build/firefox-68.0.1/config/rules.mk:413: default] Error 2
cannot build derivation '/nix/store/1dl3giwjrkqs0i97zj5vrz7j3vw1ynqa-firefox-68.0.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8z97acy8gmwknvm6zdilx78zkhz8impj-icedtea-web-1.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/388pqgq3mrixh8vwhin7kr8r6l7hgfmn-mozplugger-2.1.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wys7zmm72ca67v7s3rw6dff9b5257i5y-slimerjs-1.0.0.drv': 1 dependencies couldn't be built
note: keeping build directory '/tmp/nix-build-firefox-esr-unwrapped-68.0.1esr.drv-0'
builder for '/nix/store/6cx1xjnl891kl0vp3r8bs6hpc5jfkr6y-firefox-esr-unwrapped-68.0.1esr.drv' failed with exit code 2; last 10 log lines:
                                                 ^~~~~~~~~~~
  In file included from /build/firefox-68.0.1/obj-x86_64-pc-linux-gnu/js/src/jit/Unified_cpp_js_src_jit8.cpp:38:0:
  /build/firefox-68.0.1/js/src/jit/Recover.cpp:310:11: note: 'result' was declared here
     int32_t result;
             ^~~~~~
  make[3]: Leaving directory '/build/firefox-68.0.1/obj-x86_64-pc-linux-gnu/js/src/jit'
  make[2]: Leaving directory '/build/firefox-68.0.1/obj-x86_64-pc-linux-gnu'
  make[1]: *** [/build/firefox-68.0.1/config/recurse.mk:34: compile] Error 2
  make[1]: Leaving directory '/build/firefox-68.0.1/obj-x86_64-pc-linux-gnu'
  make: *** [/build/firefox-68.0.1/config/rules.mk:413: default] Error 2
cannot build derivation '/nix/store/568gn8rlvi9s98ryrr4jkqhbv534gax6-firefox-68.0.1esr.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0f569hyghni6pnnfm1n96iagajv7gp94-conkeror-1.0.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/477yqn814mihn16cfs13wbd26lwj8gki-env.drv': 6 dependencies couldn't be built
[3 built (2 failed), 61 copied (1958.4 MiB), 885.1 MiB DL]
error: build of '/nix/store/477yqn814mihn16cfs13wbd26lwj8gki-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/65856
6 package failed to build:
conkeror-unwrapped firefox-esr-68-unwrapped xulrunner icedtea_web mozplugger slimerjs

1 package were build:
rust-cbindgen

[0.0 MiB DL]
error: build log of '/nix/store/0f569hyghni6pnnfm1n96iagajv7gp94-conkeror-1.0.4.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/8z97acy8gmwknvm6zdilx78zkhz8impj-icedtea-web-1.7.1.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/388pqgq3mrixh8vwhin7kr8r6l7hgfmn-mozplugger-2.1.6.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/wys7zmm72ca67v7s3rw6dff9b5257i5y-slimerjs-1.0.0.drv' is not available
$ nix-shell /home/teto/.cache/nix-review/pr-65856/shell.nix

@andir

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

With Firefox 68.0.2 (both esr and non-esr) it works fine. I also managed to build the tor browser after upgrading rust-cbindgen.

@andir andir merged commit 5fd022d into NixOS:master Aug 31, 2019

15 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
rust-cbindgen on aarch64-linux Success
Details
rust-cbindgen on x86_64-linux Success
Details

@jonringer jonringer deleted the jonringer:bump-cbindgen branch Aug 31, 2019

@wizeman

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

I'm getting a hash failure downloading the cargo deps:

hash mismatch in fixed-output derivation '/nix/store/h49svhdflx5065vi7c1lz76l8fmzrw4d-rust-cbindgen-0.9.0-vendor':
  wanted: sha256:1cn84xai1n0f8xwwwwig93dawk73g1w6n6zm4axg5zl4vrmq4j6w
  got:    sha256:1l2dmvpg7114g7kczhaxv97037wdjah174xa992hv90a79kiz8da

Any idea what's going on? I thought packages from crates.io were supposed to be reproducible...

Here's my full build log

<3>unpacking sources
<3>unpacking source archive /nix/store/bh97sc86a2x5yl8v66rfjk8g78bs53li-source
<3>source root is source
<3>patching sources
<3>installing
<3>    Updating registry `https://github.com/rust-lang/crates.io-index`
<3> Downloading textwrap v0.11.0
<3> Downloading syn v0.15.38
<3> Downloading rand_core v0.4.0
<3> Downloading rand v0.6.5
<3> Downloading ansi_term v0.11.0
<3> Downloading quote v0.6.12
<3> Downloading itoa v0.4.4
<3> Downloading termion v1.5.3
<3> Downloading log v0.4.6
<3> Downloading redox_syscall v0.1.54
<3> Downloading winapi-i686-pc-windows-gnu v0.4.0
<3> Downloading tempfile v3.0.8
<3> Downloading winapi-x86_64-pc-windows-gnu v0.4.0
<3> Downloading rand_hc v0.1.0
<3> Downloading vec_map v0.8.1
<3> Downloading rand_jitter v0.1.4
<3> Downloading cloudabi v0.0.3
<3> Downloading toml v0.5.1
<3> Downloading rand_xorshift v0.1.1
<3> Downloading fuchsia-cprng v0.1.1
<3> Downloading unicode-xid v0.1.0
<3> Downloading numtoa v0.1.0
<3> Downloading rand_core v0.3.1
<3> Downloading unicode-width v0.1.5
<3> Downloading rand_isaac v0.1.1
<3> Downloading autocfg v0.1.4
<3> Downloading serde v1.0.93
<3> Downloading clap v2.33.0
<3> Downloading winapi v0.3.7
<3> Downloading serde_derive v1.0.93
<3> Downloading remove_dir_all v0.5.2
<3> Downloading cfg-if v0.1.9
<3> Downloading ryu v0.2.8
<3> Downloading rand_os v0.1.3
<3> Downloading proc-macro2 v0.4.30
<3> Downloading libc v0.2.58
<3> Downloading serde_json v1.0.39
<3> Downloading rand_chacha v0.1.1
<3> Downloading rand_pcg v0.1.2
<3> Downloading atty v0.2.11
<3> Downloading strsim v0.8.0
<3> Downloading rdrand v0.4.0
<3> Downloading bitflags v1.1.0
<3> Downloading redox_termios v0.1.1
<3>   Vendoring ansi_term v0.11.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/ansi_term-0.11.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/ansi_term
<3>   Vendoring atty v0.2.11 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/atty-0.2.11) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/atty
<3>   Vendoring autocfg v0.1.4 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/autocfg-0.1.4) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/autocfg
<3>   Vendoring bitflags v1.1.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/bitflags-1.1.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/bitflags
<3>   Vendoring cfg-if v0.1.9 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/cfg-if-0.1.9) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/cfg-if
<3>   Vendoring clap v2.33.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/clap-2.33.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/clap
<3>   Vendoring cloudabi v0.0.3 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/cloudabi-0.0.3) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/cloudabi
<3>   Vendoring fuchsia-cprng v0.1.1 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/fuchsia-cprng-0.1.1) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/fuchsia-cprng
<3>   Vendoring itoa v0.4.4 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/itoa-0.4.4) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/itoa
<3>   Vendoring libc v0.2.58 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/libc-0.2.58) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/libc
<3>   Vendoring log v0.4.6 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/log-0.4.6) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/log
<3>   Vendoring numtoa v0.1.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/numtoa-0.1.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/numtoa
<3>   Vendoring proc-macro2 v0.4.30 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/proc-macro2-0.4.30) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/proc-macro2
<3>   Vendoring quote v0.6.12 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/quote-0.6.12) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/quote
<3>   Vendoring rand v0.6.5 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/rand-0.6.5) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/rand
<3>   Vendoring rand_chacha v0.1.1 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/rand_chacha-0.1.1) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/rand_chacha
<3>   Vendoring rand_core v0.3.1 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/rand_core-0.3.1) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/rand_core-0.3.1
<3>   Vendoring rand_core v0.4.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/rand_core-0.4.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/rand_core
<3>   Vendoring rand_hc v0.1.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/rand_hc-0.1.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/rand_hc
<3>   Vendoring rand_isaac v0.1.1 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/rand_isaac-0.1.1) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/rand_isaac
<3>   Vendoring rand_jitter v0.1.4 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/rand_jitter-0.1.4) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/rand_jitter
<3>   Vendoring rand_os v0.1.3 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/rand_os-0.1.3) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/rand_os
<3>   Vendoring rand_pcg v0.1.2 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/rand_pcg-0.1.2) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/rand_pcg
<3>   Vendoring rand_xorshift v0.1.1 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/rand_xorshift-0.1.1) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/rand_xorshift
<3>   Vendoring rdrand v0.4.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/rdrand-0.4.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/rdrand
<3>   Vendoring redox_syscall v0.1.54 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/redox_syscall-0.1.54) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/redox_syscall
<3>   Vendoring redox_termios v0.1.1 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/redox_termios-0.1.1) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/redox_termios
<3>   Vendoring remove_dir_all v0.5.2 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/remove_dir_all-0.5.2) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/remove_dir_all
<3>   Vendoring ryu v0.2.8 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/ryu-0.2.8) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/ryu
<3>   Vendoring serde v1.0.93 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/serde-1.0.93) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/serde
<3>   Vendoring serde_derive v1.0.93 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/serde_derive-1.0.93) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/serde_derive
<3>   Vendoring serde_json v1.0.39 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/serde_json-1.0.39) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/serde_json
<3>   Vendoring strsim v0.8.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/strsim-0.8.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/strsim
<3>   Vendoring syn v0.15.38 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/syn-0.15.38) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/syn
<3>   Vendoring tempfile v3.0.8 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/tempfile-3.0.8) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/tempfile
<3>   Vendoring termion v1.5.3 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/termion-1.5.3) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/termion
<3>   Vendoring textwrap v0.11.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/textwrap-0.11.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/textwrap
<3>   Vendoring toml v0.5.1 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/toml-0.5.1) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/toml
<3>   Vendoring unicode-width v0.1.5 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/unicode-width-0.1.5) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/unicode-width
<3>   Vendoring unicode-xid v0.1.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/unicode-xid-0.1.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/unicode-xid
<3>   Vendoring vec_map v0.8.1 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/vec_map-0.8.1) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/vec_map
<3>   Vendoring winapi v0.3.7 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/winapi-0.3.7) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/winapi
<3>   Vendoring winapi-i686-pc-windows-gnu v0.4.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/winapi-i686-pc-windows-gnu-0.4.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/winapi-i686-pc-windows-gnu
<3>   Vendoring winapi-x86_64-pc-windows-gnu v0.4.0 (/build/source/cargo-home.0uv/registry/src/github.com-1ecc6299db9ec823/winapi-x86_64-pc-windows-gnu-0.4.0) to /nix/store/bm16vcmnpfw6yg697r2wz1kfjc58zxlp-rust-cbindgen-0.9.0-vendor/winapi-x86_64-pc-windows-gnu
<3>To use vendored sources, add this to your .cargo/config for this project:
<3>
<3>hash mismatch in fixed-output derivation '/nix/store/h49svhdflx5065vi7c1lz76l8fmzrw4d-rust-cbindgen-0.9.0-vendor':
  wanted: sha256:1cn84xai1n0f8xwwwwig93dawk73g1w6n6zm4axg5zl4vrmq4j6w
  got:    sha256:1l2dmvpg7114g7kczhaxv97037wdjah174xa992hv90a79kiz8da

@andir

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

@wizeman that is probably due to some cargo-vendor changes yet again.. It has a habit to change hashes between releases. Can you tell me which nixpkgs revision you are on?

In the long run we should fix that up...

@andir

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

I hope that the output will be more reliable now that cargo-vendor will be integrated into cargo: rust-lang/cargo@3842d8e#diff-af917df246d2ad2969f42a6d5bc447fe

@wizeman

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

I'm on revision 609fe21, a recent commit from the stable release-19.03 branch...

@andir

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

Are you also on x86_64-linux? I fail to reproduce the error :/

@jonringer

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

hmm, i didn't do a port to stable, so this shouldn't be affecting you. The only other thing i can think of is that you may have an overlay which is effecting it.

@wizeman

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

@jonringer Maybe you didn't but it seems that someone did. See https://github.com/NixOS/nixpkgs/blob/release-19.03/pkgs/development/tools/rust/cbindgen/default.nix and commit f8bcf67.

@andir Yes, I'm on x86_64-linux. Probably you can't reproduce it because your machine already has the derivation cached. This is also the reason why NixOS's Hydra instance usually doesn't notice hash changes. Try changing the cargoSha256 hash (e.g. change the last character of the cargoSha256 hash to zero) and then try building it again. Then see if the hash remains the same or if it changed.

Cargo vendor doesn't seem to have changed recently so maybe some version of a dependency was yanked from crates.io for security reasons (and a new minor version published)? Either that or crates.io was hacked and some version of a crate was replaced, which seems unlikely. Those are the only two things that occur to me that may have caused this, because dependencies taken from crates.io don't usually change.

If anyone could post a build log of the dependencies being fetched perhaps we could compare dependency versions to see if one of them has changed (due to yanking).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.