Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surf display kiosk session #65860

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@etu
Copy link
Contributor

commented Aug 3, 2019

Motivation for this change

Adds surf-display as a package which is kiosk browser session using the surf browser.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @talyz @adisbladis @aanderse

@etu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build surf-display

@etu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2019

@GrahamcOfBorg build surf-display

Building again now when openjpeg should be fixed on master

@worldofpeace
Copy link
Member

left a comment

Looks pretty good, left some comments to make it ideal.

Note I haven't verified the buildInputs yet.

pkgs/desktops/surf-display/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/surf-display/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/surf-display/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/surf-display/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Contributor

left a comment

Just noticed one small thing.

@etu etu force-pushed the etu:surf-display-kiosk-session branch from fb35490 to 51aefa7 Aug 4, 2019

@etu etu requested review from worldofpeace and aanderse Aug 4, 2019

@etu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2019

Currently everything works perfectly fine except for the configuration of the session. I will have a look at this soon. I know how to solve it.

@etu etu force-pushed the etu:surf-display-kiosk-session branch from 51aefa7 to c9a9e7a Aug 4, 2019

@etu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2019

And now the config works properly, I just imported the template config and overwrote the variables that I implemented support for in the module.

@etu etu force-pushed the etu:surf-display-kiosk-session branch 3 times, most recently from 85226d4 to 7e137bc Aug 4, 2019

@etu etu force-pushed the etu:surf-display-kiosk-session branch 2 times, most recently from 2eaac66 to b4f3e4a Aug 4, 2019

@etu etu requested review from adisbladis and worldofpeace Aug 4, 2019

@etu etu force-pushed the etu:surf-display-kiosk-session branch from b4f3e4a to 9792422 Aug 4, 2019

@etu etu force-pushed the etu:surf-display-kiosk-session branch from 9792422 to 8408232 Aug 5, 2019

@worldofpeace
Copy link
Member

left a comment

Ahh I forgot two from last time 😄

After this your pr should be good for merge if it works for you.

@etu etu force-pushed the etu:surf-display-kiosk-session branch from 8408232 to c8fda64 Aug 5, 2019

etu added 2 commits Aug 3, 2019

@etu etu force-pushed the etu:surf-display-kiosk-session branch from c8fda64 to 792da0c Aug 5, 2019

@etu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

@worldofpeace Still works perfectly fine locally 👍

@worldofpeace worldofpeace merged commit 7a53b1c into NixOS:master Aug 5, 2019

14 of 16 checks passed

surf-display on x86_64-darwin No attempt
Details
surf-display on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
surf-display on aarch64-linux Success
Details

@etu etu deleted the etu:surf-display-kiosk-session branch Aug 6, 2019

vcunat added a commit that referenced this pull request Aug 8, 2019
surf-display: fixup typo from PR #65860
It had weird effects, breaking the metrics job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.