Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgpiod: unstable-2018-10-07 -> 1.4 #65862

Merged
merged 1 commit into from Aug 3, 2019

Conversation

@jonringer
Copy link
Contributor

commented Aug 3, 2019

Motivation for this change

noticed it was in a bad state for https://repology.org/project/libgpiod/versions

used fetchurl instead of fetchgit, since it's a less-expensive operation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @expipiplus1

nix-review wip
...
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/jon/.cache/nix-review/rev-4e8a8a13ef6f730b7f785483a1ef79512a20a6fe-dirty/build.nix
[1 built, 0.0 MiB DL]
1 package were build:
libgpiod
@worldofpeace
Copy link
Member

left a comment

In configureFlags can you set prefix=$(out) to be prefix=${placeholder ''out''}?

@jonringer jonringer force-pushed the jonringer:bump-libgpiod branch from 965e4ea to 3eda38b Aug 3, 2019

@jonringer

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

done :)

@worldofpeace worldofpeace merged commit e1f14ce into NixOS:master Aug 3, 2019

15 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libgpiod on aarch64-linux Success
Details
libgpiod on x86_64-linux Success
Details
@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Thanks @jonringer

@jonringer jonringer deleted the jonringer:bump-libgpiod branch Aug 8, 2019

@expipiplus1

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.