Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolphinEmuMaster: update to the latest upstream version #65863

Closed
wants to merge 1 commit into from

Conversation

@marius851000
Copy link
Contributor

commented Aug 3, 2019

Motivation for this change

dolphinEmuMaster failed to compile. Updating to the latest version made it work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Question:

What does the "9976" in version mean and by what should I replace it ?

Notify maintainers

cc @MP2E

@MP2E

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

LGTM, though make sure to change the version number too. I went ahead and did that and merged it in as of

f2068d3

@MP2E MP2E closed this Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.