Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono: remove outdated workaround; pythonPackages.pythonnet: 2.3.0 -> 2.4.0 #65875

Merged
merged 2 commits into from Feb 9, 2020

Conversation

@jirkadanek
Copy link
Member

@jirkadanek jirkadanek commented Aug 3, 2019

Motivation for this change

New major release of Mono. Fix previously broken pythonPackages.pythonnet. The release notes for 2.4.0 newly mention support for Python 3.7.

The following packages are still failing to build in nix-review, but they were failing even before this change and I don't know how to fix them quickly.

  • dotnetPackages.ExtCore
  • dotnetPackages.FSharpAutoComplete
  • dotnetPackages.FSharpCompilerService
  • gdata-sharp
  • mono-zeroconf
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @obadz @vrthra @jraygauthier

@jirkadanek jirkadanek requested a review from FRidh as a code owner Aug 3, 2019
@jirkadanek jirkadanek changed the title Jd mono6 mono6: Init at 6.0.0.313; pythonPackages.pythonnet: 2.3.0 -> 2.4.0 Aug 3, 2019
@ofborg ofborg bot requested review from obadz, vrthra and thoughtpolice Aug 3, 2019
Copy link
Member

@jraygauthier jraygauthier left a comment

The pythonnet part seems fine.

This was referenced Aug 5, 2019
@jirkadanek
Copy link
Member Author

@jirkadanek jirkadanek commented Aug 6, 2019

Would it be a good idea to split the PR more? Each commit its own PR?

@@ -20,9 +22,6 @@ stdenv.mkDerivation rec {

NIX_LDFLAGS = if stdenv.isDarwin then "" else "-lgcc_s" ;

# To overcome the bug https://bugzilla.novell.com/show_bug.cgi?id=644723
dontDisableStatic = true;

This comment has been minimized.

@jraygauthier

jraygauthier Aug 7, 2019
Member

Won't this impact previous (<6) version of mono?

This comment has been minimized.

@jirkadanek

jirkadanek Aug 7, 2019
Author Member

I did nix-review and all compiled and what I tried to run worked well, or at least no worse than before. Notice the bugzilla is quite ancient. I removed it based on suggestion in #58797 (comment).

This comment has been minimized.

@jraygauthier

jraygauthier Aug 7, 2019
Member

Ok then.

@jraygauthier
Copy link
Member

@jraygauthier jraygauthier commented Aug 7, 2019

Seems like fine job as a whole. If the above about dontDisableStatic do not impact previous mono maintained mono versions, this seems fine to me.

@jirkadanek jirkadanek changed the title mono6: Init at 6.0.0.313; pythonPackages.pythonnet: 2.3.0 -> 2.4.0 mono6: remove outdated workaround; pythonPackages.pythonnet: 2.3.0 -> 2.4.0 Aug 27, 2019
@jirkadanek jirkadanek force-pushed the jirkadanek:jd_mono6 branch from 874c709 to f26f4be Aug 27, 2019
@jirkadanek
Copy link
Member Author

@jirkadanek jirkadanek commented Aug 27, 2019

The mono6 part of the PR was merged as part of PR #66299 in commit a9b4e75

@jirkadanek jirkadanek changed the title mono6: remove outdated workaround; pythonPackages.pythonnet: 2.3.0 -> 2.4.0 mono: remove outdated workaround; pythonPackages.pythonnet: 2.3.0 -> 2.4.0 Aug 27, 2019
@FRidh FRidh merged commit 002fc5f into NixOS:master Feb 9, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.