Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sam-cli: 0.16.1 -> 0.19.0 #66125

Closed
wants to merge 3 commits into from
Closed

Conversation

@jonringer
Copy link
Contributor

jonringer commented Aug 5, 2019

Motivation for this change

Saw a weird error while reviewing another pr

Actions:

  • python2 -> python3
  • version bump
  • made python2 only libs optional
  • added longDescription
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andreabedini
@FRidh because it's most a python package.

pkgs/development/tools/aws-sam-cli/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/aws-sam-cli/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@jonringer jonringer force-pushed the jonringer:bump-aws-sam branch from 0e8ca70 to d4a8eb5 Aug 7, 2019
@jonringer
Copy link
Contributor Author

jonringer commented Aug 7, 2019

Rebased on top of master, and applied changes.

@jonringer jonringer force-pushed the jonringer:bump-aws-sam branch from d4a8eb5 to 623bd93 Sep 29, 2019
@jonringer
Copy link
Contributor Author

jonringer commented Sep 29, 2019

@GrahamcOfBorg build aws-sam-cli

@jonringer
Copy link
Contributor Author

jonringer commented Sep 29, 2019

@worldofpeace @marsam rebased on top of master, applied changes 6 weeks ago :)

@worldofpeace
Copy link
Member

worldofpeace commented Sep 29, 2019

@jonringer We'll see about integrating. And commit bit soon 🤣

@ofborg ofborg bot requested a review from dhl Sep 29, 2019
@jonringer jonringer force-pushed the jonringer:bump-aws-sam branch from 623bd93 to 2a7a9a3 Sep 29, 2019
@jonringer jonringer requested a review from FRidh as a code owner Sep 29, 2019
@jonringer
Copy link
Contributor Author

jonringer commented Sep 29, 2019

@GrahamcOfBorg build aws-sam-cli

@jonringer
Copy link
Contributor Author

jonringer commented Sep 29, 2019

bumped and no regressions

[3 built, 1 copied (0.1 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66125
5 package were build:
aws-sam-cli python27Packages.aws-lambda-builders python27Packages.serverlessrepo python37Packages.aws-lambda-builders python37Packages.serverlessrepo
@ofborg ofborg bot added the 6.topic: python label Sep 29, 2019
@jonringer
Copy link
Contributor Author

jonringer commented Nov 25, 2019

master is now at 0.22.0, closing

@jonringer jonringer closed this Nov 25, 2019
@jonringer jonringer deleted the jonringer:bump-aws-sam branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.