Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfive: 2018-07-01 -> 2019-08-05 #66128

Closed
wants to merge 1 commit into from
Closed

libfive: 2018-07-01 -> 2019-08-05 #66128

wants to merge 1 commit into from

Conversation

@Hodapp87
Copy link
Contributor

Hodapp87 commented Aug 5, 2019

Motivation for this change

Updating libfive to a newer version, closer to their last release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse
Copy link
Contributor

aanderse commented Aug 31, 2019

@Hodapp87 I'm guessing the binary provided by this package is a graphical program utilizing qt, right? You should take a look at #65399.

@doronbehar
Copy link
Contributor

doronbehar commented Feb 23, 2020

Also, fix the merge conflicts.

KoviRobi added a commit to KoviRobi/nixpkgs that referenced this pull request Mar 29, 2020
Use proper Qt bindings (NixOS#65399). Note, current version didn't work for
me, new version does.

The libfive library is licensed under MPL 2.0, while the libfive-guile
and libfive-studio are under GPL 2+

Superseeds NixOS#66128
@KoviRobi KoviRobi mentioned this pull request Mar 29, 2020
4 of 10 tasks complete
KoviRobi added a commit to KoviRobi/nixpkgs that referenced this pull request Mar 29, 2020
Use proper Qt bindings (NixOS#65399). Note, current version didn't work for
me, new version does.

The libfive library is licensed under MPL 2.0, while the libfive-guile
and libfive-studio are under GPL 2+

Superseeds NixOS#66128
@srhb srhb closed this in #83711 May 14, 2020
srhb pushed a commit that referenced this pull request May 14, 2020
Use proper Qt bindings (#65399). Note, current version didn't work for
me, new version does.

The libfive library is licensed under MPL 2.0, while the libfive-guile
and libfive-studio are under GPL 2+

Superseeds #66128
dashmoho pushed a commit to dashmoho/nixpkgs that referenced this pull request May 14, 2020
Use proper Qt bindings (NixOS#65399). Note, current version didn't work for
me, new version does.

The libfive library is licensed under MPL 2.0, while the libfive-guile
and libfive-studio are under GPL 2+

Superseeds NixOS#66128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.