Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.bugwarrior: depend on jira, remove unused test deps #66234

Merged
merged 1 commit into from Jan 7, 2020

Conversation

@yurrriq
Copy link
Member

@yurrriq yurrriq commented Aug 6, 2019

Motivation for this change
  • Add Jira support
  • Comment out unused test dependencies
  • Drop Python 2.7 support, per upstream
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@yurrriq
Copy link
Member Author

@yurrriq yurrriq commented Aug 6, 2019

@GrahamcOfBorg build python35Packages.bugwarrior python37Packages.bugwarrior

@yurrriq yurrriq force-pushed the yurrriq:update-bugwarrior branch from 97ce5d2 to 8e5faeb Sep 2, 2019
@yurrriq
Copy link
Member Author

@yurrriq yurrriq commented Oct 23, 2019

Anything blocking merging this? /ping @FRidh

@yurrriq
Copy link
Member Author

@yurrriq yurrriq commented Nov 2, 2019

/ping @Mic92, any chance you can help me out here too? 😇

@yurrriq
Copy link
Member Author

@yurrriq yurrriq commented Dec 19, 2019

any update on this?

@yurrriq yurrriq force-pushed the yurrriq:update-bugwarrior branch from 8e5faeb to 6a98369 Dec 22, 2019
@yurrriq yurrriq requested a review from jonringer as a code owner Dec 22, 2019
@yurrriq yurrriq force-pushed the yurrriq:update-bugwarrior branch from 6a98369 to e4c7a71 Dec 22, 2019
@yurrriq
Copy link
Member Author

@yurrriq yurrriq commented Dec 22, 2019

@GrahamcOfBorg build python36Packages.bugwarrior python37Packages.bugwarrior

Copy link
Contributor

@jonringer jonringer left a comment

please squash the commits

git reset HEAD~5
git add pkgs/
git commit -m "pythonPackages.bugwarrior: depend on jira, comment out test deps"
git push <fork> <branch> --force
@yurrriq yurrriq force-pushed the yurrriq:update-bugwarrior branch from e4c7a71 to aebfc9d Dec 23, 2019
@yurrriq
Copy link
Member Author

@yurrriq yurrriq commented Dec 23, 2019

I can't (be bothered to) get it to build for pythonOlder "3.8" now, so I've updated disabled accordingly.

@yurrriq
Copy link
Member Author

@yurrriq yurrriq commented Dec 23, 2019

@GrahamcOfBorg build python38Packages.bugwarrior

@yurrriq yurrriq changed the title pythonPackages.bugwarrior: depend on jira, comment out test deps pythonPackages.bugwarrior: depend on jira, remove unused test deps Dec 23, 2019
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 23, 2019

we're doing a large update to the the python ecosystem in #76059, please just hold on a bit, it will make your other python versions much easier to package

@yurrriq yurrriq force-pushed the yurrriq:update-bugwarrior branch from aebfc9d to 632123e Dec 30, 2019
@yurrriq
Copy link
Member Author

@yurrriq yurrriq commented Dec 30, 2019

There's a problem with taskw -> tox -> importlib-metadata on python 3.5-3.7.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 30, 2019

python-unstable was merged into staging next, once #76705 gets merged, this shouldn't be an issue

@FRidh FRidh changed the base branch from master to staging-next Dec 30, 2019
@FRidh FRidh changed the base branch from staging-next to master Dec 30, 2019
@yurrriq yurrriq force-pushed the yurrriq:update-bugwarrior branch from 632123e to 350d6a6 Jan 4, 2020
@yurrriq
Copy link
Member Author

@yurrriq yurrriq commented Jan 7, 2020

Hmm.. after rebasing on #76705, this doesn't work anymore. Any tips? I'm not much into Python these days.

ModuleNotFoundError: No module named 'pkg_resources'
@yurrriq yurrriq changed the title pythonPackages.bugwarrior: depend on jira, remove unused test deps WIP: pythonPackages.bugwarrior: depend on jira, remove unused test deps Jan 7, 2020
- drop support for 2.7, per upstream
- remove half-baked checkInputs, but leave comment
- add yurrriq as maintainer
- add setuptools to propagatedBuildInputs
@yurrriq yurrriq force-pushed the yurrriq:update-bugwarrior branch from 350d6a6 to 703adfe Jan 7, 2020
@yurrriq yurrriq changed the title WIP: pythonPackages.bugwarrior: depend on jira, remove unused test deps pythonPackages.bugwarrior: depend on jira, remove unused test deps Jan 7, 2020
@yurrriq
Copy link
Member Author

@yurrriq yurrriq commented Jan 7, 2020

All good with setuptools now.

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM

[4 built, 63 copied (40.1 MiB), 8.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66234
2 package built:
python37Packages.bugwarrior python38Packages.bugwarrior
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 7, 2020

@GrahamcOfBorg build python37Packages.bugwarrior python38Packages.bugwarrior

@jonringer jonringer merged commit 826df23 into NixOS:master Jan 7, 2020
15 of 16 checks passed
15 of 16 checks passed
python37Packages.bugwarrior, python38Packages.bugwarrior on x86_64-linux
Details
python37Packages.bugwarrior, python38Packages.bugwarrior on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python37Packages.bugwarrior, python38Packages.bugwarrior on x86_64-darwin Success
Details
@jonringer jonringer added this to Done in Python 2 deprecation via automation Jan 7, 2020
@yurrriq
Copy link
Member Author

@yurrriq yurrriq commented Jan 7, 2020

🎉 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.