Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.git-revise: init at 0.4.2 #66280

Closed
wants to merge 1 commit into from

Conversation

@mmlb
Copy link
Contributor

commented Aug 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bdesham

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

I tried this out on Ubuntu and it seemed to work fine. Thanks for packaging it!

@emilazy

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

oops, I'm sorry for the duplicated work -- I didn't see this before filing #66509 ^^;

@mmlb

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@emilazy no worries

@mmlb mmlb closed this Aug 14, 2019

@mmlb mmlb deleted the mmlb:init-python-package-git-revise branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.