Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsharp41: 4.1.7 -> 4.1.34; mono = mono6 #66299

Merged
merged 4 commits into from Aug 26, 2019

Conversation

@jdanekrh
Copy link
Member

commented Aug 7, 2019

Motivation for this change

Update another consumer of mono4. Together with #66255, there should be no uses of mono4 left in the nixpkgs tree.

Depends on #66134 for msbuild.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @7c6f434c

jdanekrh added 4 commits Aug 3, 2019
Copy link
Member

left a comment

It's a pity that apparently there is no trivial-to-verify way to make sure that myget.org references go to the proper builds of the dependencies, but apparently this is hard to avoid.

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

@GrahamcOfBorg build fsharp41

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

@GrahamcOfBorg build msbuild

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

@GrahamcOfBorg build dotnetPackages.Nuget

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

@GrahamcOfBorg build mono6

1 similar comment
@jdanekrh

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

@GrahamcOfBorg build mono6

@jdanekrh

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

mono6 on x86_64-darwin timed out for no (to me) obvious reason. wanted to try if maybe I can retrigger it unchanged. apparently not.

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@GrahamcOfBorg build mono6

@jdanekrh

This comment has been minimized.

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

yeah, @NixOS/darwin-maintainers anyone willing to give this a try please? :)

@obadz obadz merged commit a9b4e75 into NixOS:master Aug 26, 2019
20 of 25 checks passed
20 of 25 checks passed
fsharp41 on aarch64-linux No attempt
Details
fsharp41 on x86_64-darwin No attempt
Details
mono6 on x86_64-darwin Timed out, unknown build status
Details
msbuild on aarch64-linux No attempt
Details
msbuild on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
dotnetPackages.Nuget on aarch64-linux Success
Details
dotnetPackages.Nuget on x86_64-darwin Success
Details
dotnetPackages.Nuget on x86_64-linux Success
Details
fsharp41 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mono6 on aarch64-linux Success
Details
mono6 on x86_64-linux Success
Details
msbuild on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.