Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl: 5.28.2 -> 5.30.0 #66385

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@volth
Copy link
Contributor

commented Aug 9, 2019

It works for me, but as it affects everything I cannot say that it is fully tested.
At least we will have time to test before making decision which perl will be default in 19.09

5.30.0 is about 3 month old and there were no urgent bugfixes or something like that, so it should be stable and already tested on bleeding edge distros.

@aanderse

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

Changelog doesn't seem that crazy. Given how NixOS is fairly cutting edge (and I mean come on... it's perl) generally I think it would make sense to use this. We're just under 2 months from a new NixOS release so does that give us enough time to fix any potential regressions which come up? I'm going to guess yes. I think it should be either @lheckemann or @disassembler who merge this, though, as perl is a really core component that touches so much.

@lheckemann

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

I've run the simple UEFI installer test, which seems to work fine on aarch64, and the e2fsprogs build fails for unrelated reasons (building on zfs?) on x86_64-linux, so I'd say we should merge this and see how it goes on staging.

@lheckemann lheckemann merged commit a6055b7 into NixOS:staging Aug 14, 2019

14 of 15 checks passed

perl on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
perl on aarch64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.