Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subversion: 1.9.9 -> 1.9.12, 1.10.4 -> 1.10.6 [19.03 backport] #66440

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@aanderse
Copy link
Contributor

commented Aug 10, 2019

Motivation for this change

Fix for CVE-2018-11782 and CVE-2019-0203.
Backport of #66439.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse aanderse changed the title subversion: 1.9.9 -> 1.9.12, 1.10.4 -> 1.10.6 subversion: 1.9.9 -> 1.9.12, 1.10.4 -> 1.10.6 [19.03 backport] Aug 10, 2019
@ofborg ofborg bot requested review from edolstra and lovek323 Aug 10, 2019
@aanderse

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

@GrahamcOfBorg test subversion

@vcunat

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

Hmm, we do have nixos/tests/subversion.nix but I can't see it linked as an attribute.

@aanderse

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Hmm, we do have nixos/tests/subversion.nix but I can't see it linked as an attribute.

Yeah, it looks like it should be removed because it references a file which doesn't exist and it uses the deprecated services.httpd.extraSubservices.

@vcunat

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

Well, 19.03 is a dead-end branch, so we don't really need to clean up there, but on master it seems to be the same.

@aanderse

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Yeah, sorry, I meant in master. I'll look into that over the next few days likely.

@risicle

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

WFM macos 10.13

@aanderse aanderse requested a review from andir Aug 11, 2019
@aanderse aanderse merged commit 94b5774 into NixOS:release-19.03 Aug 21, 2019
15 of 18 checks passed
15 of 18 checks passed
subversion on x86_64-darwin Timed out, unknown build status
Details
tests.subversion on aarch64-linux No attempt
Details
tests.subversion on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
subversion on aarch64-linux Success
Details
subversion on x86_64-linux Success
Details
@aanderse aanderse deleted the aanderse:subversion-backport branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.