Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/fuse: init #66480

Merged
merged 2 commits into from Aug 14, 2019

Conversation

@primeos
Copy link
Member

commented Aug 11, 2019

Add a module for /etc/fuse.conf.
Fixes #30923.

This was requested multiple times now so it seems to be worth a module.

TODOs for review/discussion (optional, the current implementation already works and is ready to be merged):

  • Is the path/namespace ok? program.fuse loooks better, than e.g. fuse.* but I would assume that most program.* modules usually have an enable option.
  • Do we need an enable option? This could be useful to prevent fuse and fuse3 from being installed, avoid the suid binaries, and blacklist the kernel module (but it should remain enabled by default).
  • Should I move all fuse related logic into this module? I.e. from nixos/modules/profiles/base.nix and nixos/modules/security/wrappers/default.nix?
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

nixos/fuse: init
Add a module for /etc/fuse.conf.
Fixes #30923.
@rasendubi
Copy link
Member

left a comment

Nitpick. Otherwise, looks good.

@rasendubi

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Do we need an enable option?
Should I move all fuse related logic into this module?

I would say "yes" to both:

  • programs.fuse name makes much more sense then
  • pulling all pieces together makes the module easier to understand

The module is fine to merge as is, though.

Looking through profiles/base.nix and security/wrappers I am not sure why profiles/base.nix puts fuse into systemPackages—security wrappers look like fuse and fuse3 binaries are always installed.

Fix the indentation
Co-Authored-By: Alexey Shmalko <rasen.dubi@gmail.com>

@matthewbauer matthewbauer merged commit 3411c15 into NixOS:master Aug 14, 2019

12 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.