Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quassel: use wrapQtAppsHook for the client #66550

Open
wants to merge 1 commit into
base: master
from

Conversation

@Shados
Copy link
Contributor

commented Aug 13, 2019

Motivation for this change

#65399

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Phreedom @ttuegel

@peterhoeg

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Since we are calling it with libsForQt5.callPackage, you don't have to manually use wrapQtAppsHook. The qt provided mkDerivation will do the trick (instead stdenv.mkDerivation).

@Shados

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@peterhoeg Does the core actually need wrapping...? I'll go find out, I guess.

@@ -4,7 +4,7 @@
, tag ? "-kf5" # tag added to the package name
, static ? false # link statically

, stdenv, fetchFromGitHub, cmake, makeWrapper, dconf
, stdenv, fetchFromGitHub, cmake, makeWrapper, dconf, wrapQtAppsHook

This comment has been minimized.

Copy link
@ttuegel

ttuegel Aug 13, 2019

Member

Because the dependency on Qt is unconditional, it is preferred to import mkDerivation and use that below instead of stdenv.mkDerivation.

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

I'm pretty sure you should wrap the core as well.

@Shados

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

@ttuegel @worldofpeace I tested, quasselcore runs fine without wrapping. It does still use Qt, but it appears that all its Qt dependencies are compile-time -- there's apparently no run-time dependency on any plugins, and obviously not on any style engines or other GUI components.

@ttuegel

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

It does still use Qt, but it appears that all its Qt dependencies are compile-time -- there's apparently no run-time dependency on any plugins, and obviously not on any style engines or other GUI components.

IIRC, it doesn't link libQt5Gui.so, so this sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.