Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh: use host derivation to run binary when cross compiling #66573

Closed
wants to merge 1 commit into from

Conversation

@eadwu
Copy link
Contributor

commented Aug 13, 2019

I have no clue whether or not this is the correct way to do it but it builds.
Seems to work fine on aarch64 and x86_64.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from pSub Aug 13, 2019

@eadwu eadwu marked this pull request as ready for review Aug 13, 2019

@lopsided98

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

This looks good (I didn't test it), but you might consider refactoring it to use a zshForBuild variable, so you don't have to repeat the whole command. See https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/python/cpython/default.nix#L62 for a similar example.

@eadwu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@eadwu eadwu closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.