Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bot] name -> pname (easy cases) #66585

Merged
merged 48 commits into from Aug 15, 2019

Conversation

@volth
Copy link
Contributor

commented Aug 13, 2019

treewide replacement of

stdenv.mkDerivation rec {
  name = "*-${version}";
  version = "*";

to pname

cc @worldofpeace #61691

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Is this worth the huge rebuild? We should probably be fixing it over time with updates?

@volth volth closed this Aug 13, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@mmahut I think we should start to getting everything using pname if we can.

@mmahut

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@worldofpeace I agree. Maybe we can create an GrahamcOfBorg that will check if new merges are fixing the pname as well? Or maybe just one large rebuild will do? In that case, maybe it should go to staging first?

@worldofpeace

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@mmahut I'm guessing that's why volth closed this.

Or maybe just one large rebuild will do?

Since we group mass rebuilds together into staging-next we're going to do a mass rebuild continuously anyway.

@volth volth reopened this Aug 13, 2019

@volth volth force-pushed the volth:pname branch from efca6cd to 7d874b5 Aug 13, 2019

@volth volth requested review from LnL7, Mic92 and ttuegel as code owners Aug 13, 2019

@volth volth changed the base branch from master to staging Aug 13, 2019

@volth volth reopened this Aug 15, 2019

@volth volth force-pushed the volth:pname branch from f7dcff7 to e8ec3cf Aug 15, 2019

@Mic92 Mic92 merged commit 46420bb into NixOS:staging Aug 15, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@volth

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

@Mic92 maybe also volth@e82ae09

@Mic92

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

@volth can you open this in a PR for the sake of eval checks?

@volth volth referenced this pull request Aug 17, 2019
@volth

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

@volth can you open this in a PR for the sake of eval checks?

#66751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.