Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solc: 0.5.10 -> 0.5.11 #66604

Closed
wants to merge 1 commit into from

Conversation

@xrelkd
Copy link
Contributor

commented Aug 14, 2019

Motivation for this change

Update solc to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dbrock @akru @lionello @sifmelcara

@xrelkd

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

This PR is closed because of the following errors:

--- SKIPPING ALL SEMANTICS TESTS ---

Running 2879 test cases...

0%   10   20   30   40   50   60   70   80   90   100%
|----|----|----|----|----|----|----|----|----|----|
*******/tmp/nix-build-solc-0.5.11.drv-0/source/test/libsolidity/AnalysisFramework.cpp(65): fatal error: in "SMTChecker/division": Multiple errors found: :9:17: Warning: Overflow (resulting value larger than 2**256 - 1) might happen here.
                                uint256 c = a * b;
                                            ^---^

:10:13: Warning: Division by zero happens here
                                require(c / a == b);
                                        ^---^
  for:
   = 0
  <result> = 0
  a = 0
  b = 0
  c = 0

Callstack:


********************************************

*** 1 failure is detected in the test module "SolidityTests"

builder for '/nix/store/mkwpgc0q9xp804zdadd9rx6r1z1zy2jl-solc-0.5.11.drv' failed with exit code 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.