Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

super-user-spark 0.3.2.0-dev -> 0.4.0.1 #66610

Open
wants to merge 2 commits into
base: master
from

Conversation

@NorfairKing
Copy link

commented Aug 14, 2019

Motivation for this change

Upgrade.

Disclaimer

This is my first contribution and I'm not sure how to test this change. Please help?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @badi

@badi

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Hi! Welcome!

You can test by running

nix-build -A super-user-spark

in the root of your nixpkgs checkout (I like adding --dry-run to see a plan first).

A successful build will create $PWD/result as a symlink to the installation so you can run eg:

./result/bin/spark parse ...

I get the following on a nix-build:

test/SuperUserSpark/Compiler/Gen.hs:29:10: error:
    • Could not deduce (GenUnchecked a)
        arising from a use of ‘Data.GenValidity.$dmshrinkValid’
      from the context: GenValid a
        bound by the instance declaration
        at test/SuperUserSpark/Compiler/Gen.hs:(29,10)-(30,32)
      Possible fix:
        add (GenUnchecked a) to the context of the instance declaration
    • In the expression:
        Data.GenValidity.$dmshrinkValid @(Deployment a)
      In an equation for ‘shrinkValid’:
          shrinkValid = Data.GenValidity.$dmshrinkValid @(Deployment a)
      In the instance declaration for ‘GenValid (Deployment a)’
   |
29 | instance GenValid a =>
   |          ^^^^^^^^^^^^^...

test/SuperUserSpark/Compiler/Gen.hs:36:10: error:
    • Could not deduce (GenUnchecked a)
        arising from a use of ‘Data.GenValidity.$dmshrinkValid’
      from the context: GenValid a
        bound by the instance declaration
        at test/SuperUserSpark/Compiler/Gen.hs:(36,10)-(37,42)
      Possible fix:
        add (GenUnchecked a) to the context of the instance declaration
    • In the expression:
        Data.GenValidity.$dmshrinkValid @(DeploymentDirections a)
      In an equation for ‘shrinkValid’:
          shrinkValid
            = Data.GenValidity.$dmshrinkValid @(DeploymentDirections a)
      In the instance declaration for ‘GenValid (DeploymentDirections a)’
   |
36 | instance GenValid a =>
   |          ^^^^^^^^^^^^^...
Tom Sydney Kerckhove
@NorfairKing

This comment has been minimized.

Copy link
Author

commented Aug 14, 2019

Alright @badi Great feedback. I just released (on hackage) a new version that doesn't have this build error.
The tests pass for me locally but not on nix, so I turned them off for now.

@badi

badi approved these changes Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.