Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildRustPackage: support cross-compilation to x86_64-pc-mingw32 #66613

Merged

Conversation

@yegortimoshenko
Copy link
Member

commented Aug 14, 2019

Motivation for this change

Allows to build Rust packages on Windows. Intended usage scenario is:

let
  nixpkgs-mozilla = import (fetchTarball {
    url = "https://github.com/mozilla/nixpkgs-mozilla/archive/ac8e9d7bbda8fb5e45cae20c5b7e44c52da3ac0c.tar.gz";
    sha256 = "1irlkqc0jdkxdfznq7r52ycnf0kcvvrz416qc7346xhmilrx2gy6";
  });
in

with import <nixpkgs> { overlays = [ nixpkgs-mozilla ]; };

let
  rustChannel = rustChannelOfTargets "nightly" "2019-07-14" [ "x86_64-pc-windows-gnu" ];
  rustPlatform = pkgsCross.mingwW64.makeRustPlatform {
    cargo = rustChannel;
    rustc = rustChannel;
  };
in

rustPlatform.buildRustPackage {
  name = "example";
  src = lib.cleanSource ./.;

  preConfigure = ''
    export HOME=$(mktemp -d)
  '';

  cargoSha256 = "0000000000000000000000000000000000000000000000000000";
}
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ericson2314 @matthewbauer

@yegortimoshenko yegortimoshenko force-pushed the transumption-unstable:201908/rust-win32-cross branch from fc44b0f to 7e5fa16 Aug 14, 2019

@yegortimoshenko yegortimoshenko force-pushed the transumption-unstable:201908/rust-win32-cross branch 3 times, most recently from d905599 to 04bfa7b Aug 14, 2019

yegortimoshenko added a commit to Holo-Host/holoportos that referenced this pull request Aug 14, 2019

@yegortimoshenko

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

(cc @Mic92)

homepage = "https://sourceware.org/pthreads-win32";
license = licenses.lgpl21Plus;
maintainers = with maintainers; [ yegortimoshenko ];
platforms = platforms.windows;

This comment has been minimized.

Copy link
@Ericson2314

Ericson2314 Aug 15, 2019

Member

CC @angerman was this all broken?

This comment has been minimized.

Copy link
@yegortimoshenko

yegortimoshenko Aug 15, 2019

Author Member

It probably was, nix-build '<nixpkgs>' -A pkgsCross.mingwW64.windows.pthreads --no-out-link fails on No rule to make target 'w32api.h.in', needed by 'w32api.h' as of recent master.

yegortimoshenko added some commits Aug 14, 2019

@yegortimoshenko yegortimoshenko force-pushed the transumption-unstable:201908/rust-win32-cross branch from 04bfa7b to da3da08 Aug 15, 2019

@Ericson2314 Ericson2314 merged commit d13a1bc into NixOS:master Aug 15, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@yegortimoshenko

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

@yegortimoshenko yegortimoshenko deleted the transumption-unstable:201908/rust-win32-cross branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.